[Delegation Toolkit] Improve code snippets#2101
Merged
AyushBherwani1998 merged 7 commits intomainfrom Jun 24, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
delegation-toolkit/how-to/create-smart-account/configure-accounts-signers.md
Outdated
Show resolved
Hide resolved
Comment on lines
112
to
117
| :::info Installation required | ||
|
|
||
| To estimate the gas fee, we'll use the [permissionless.js](https://docs.pimlico.io/references/permissionless/) SDK. Please make sure the SDK is installed. | ||
|
|
||
| ::: | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| :::info Installation required | |
| To estimate the gas fee, we'll use the [permissionless.js](https://docs.pimlico.io/references/permissionless/) SDK. Please make sure the SDK is installed. | |
| ::: |
Can you add this to the prerequisites section instead?
[Install the permissionless.js SDK.](https://docs.pimlico.io/references/permissionless/)
Member
Author
There was a problem hiding this comment.
It's not a prerequisite for sending user operation, but a prerequisite for estimating fees when using Pimlico's bundler. If someone wishes to uses Zerodev, thirdWeb, or some other bundler it won't be a prerequisite for them.
Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com>
Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves code snippets
Fixes #
Preview
https://metamask-docs-git-fix-code-snippets-consensys-ddffed67.vercel.app/delegation-toolkit/
Checklist
Complete this checklist before merging your PR: