-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[Delegation Toolkit] Improve code snippets #2101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
e25f4dd
e9d0fc1
a355fdb
a517947
59809bd
2fefd3e
e808053
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -109,6 +109,12 @@ The following example updates the previous example to estimate the fees. | |||||||||||
| This example uses constant values, but the [Hello Gator example](https://github.com/MetaMask/hello-gator) uses Pimlico's Alto bundler, | ||||||||||||
| which fetches user operation gas price using the RPC method [`pimlico_getUserOperationPrice`](https://docs.pimlico.io/infra/bundler/endpoints/pimlico_getUserOperationGasPrice). | ||||||||||||
|
|
||||||||||||
| :::info Installation required | ||||||||||||
|
|
||||||||||||
| To estimate the gas fee, we'll use the [permissionless.js](https://docs.pimlico.io/references/permissionless/) SDK. Please make sure the SDK is installed. | ||||||||||||
AyushBherwani1998 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||||||
|
|
||||||||||||
| ::: | ||||||||||||
|
|
||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Can you add this to the prerequisites section instead?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's not a prerequisite for sending user operation, but a prerequisite for estimating fees when using Pimlico's bundler. If someone wishes to uses Zerodev, thirdWeb, or some other bundler it won't be a prerequisite for them. |
||||||||||||
| ```typescript title="example.ts" | ||||||||||||
| // add-next-line | ||||||||||||
| + import { createPimlicoClient } from "permissionless/clients/pimlico"; | ||||||||||||
|
|
||||||||||||
Uh oh!
There was an error while loading. Please reload this page.