Skip to content

feat: default shield env to main using dev local build #38522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tuna1207 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: default shield env to main using dev local build #38522

tuna1207 wants to merge 1 commit into from
+6 −2

Conversation

@tuna1207
Copy link
Member

@tuna1207 tuna1207 commented Dec 3, 2025 •
edited by cursor bot
Loading

Description

Previously dev local build shied config default to dev env but profile sync default to prd env which cause mismatch and require dev to update profile sync or shield env to match in local, this default shield env to use prd to match other services env.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Only TEST environment now maps to dev Shield config; development defaults to main, with a new isTestEnvironment() helper and refactored checks.

  • Shield config selection:
    • Update loadShieldConfig to use isTestEnvironment(); only TEST env maps to BUILD_TYPE.dev, development now defaults to BUILD_TYPE.main.
  • Utils:
    • Add isTestEnvironment().
    • Refactor isDevOrTestEnvironment() to call isTestEnvironment().

Written by Cursor Bugbot for commit 5df6cdb. This will update automatically on new commits. Configure here.

@metamaskbot metamaskbot added the team-onboarding Onboarding team label Dec 3, 2025
@tuna1207 tuna1207 added area-shield team-shield Shield team and removed team-onboarding Onboarding team labels Dec 3, 2025
@tuna1207 tuna1207 marked this pull request as ready for review December 3, 2025 13:50
lwin-kyaw
lwin-kyaw reviewed Dec 3, 2025
View reviewed changes
shared/modules/shield/config.ts

let buildTypeEnv: BuildType = BUILD_TYPE.main;
if (isDevOrTestEnvironment()) {
if (isTestEnvironment()) {
Copy link
Contributor

@lwin-kyaw lwin-kyaw Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local dev build with yarn start is pointing to prod env. Is it expected?

Copy link
Member Author

@tuna1207 tuna1207 Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's the purpose of this PR, so it match local dev default for profile sync controller (also prod env)

@metamaskbot
Copy link
Collaborator

metamaskbot commented Dec 3, 2025

Builds ready [5df6cdb]
UI Startup Metrics (1204 ± 115 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1204998154811512851426
load101083312719410751210
domContentLoaded100482712589410621205
domInteractive2514110192181
firstPaint60978127941410381170
backgroundConnect20718227615214233
firstReactRender291986113251
getState3516125203798
initialActions104112
loadScripts803644103690847977
setupStore1174051218
numNetworkReqs1157017565
BrowserifyPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
WebpackStandard HomeuiStartup819701104068858958
load64456286471686775
domContentLoaded63955985871683767
domInteractive2715108222392
firstPaint20189772125192590
backgroundConnect1057181227
firstReactRender2820109113040
getState251357103344
initialActions104112
loadScripts63755684869681761
setupStore1072731216
numNetworkReqs1156817564
WebpackPower User HomeuiStartup16061252221321116642063
load692597111291695917
domContentLoaded681592110091680910
domInteractive38191512935122
firstPaint2851091112218253897
backgroundConnect45762611619406
firstReactRender61478486677
getState19013074277187223
initialActions103112
loadScripts678590109089677900
setupStore211053112450
numNetworkReqs1626841466217280
FirefoxBrowserifyStandard HomeuiStartup12791076175113013621511
load106593012628511331207
domContentLoaded106492912628511331206
domInteractive57312773582109
firstPaint------
backgroundConnect4022162224093
firstReactRender22173742233
getState136115151136
initialActions102012
loadScripts104091312437911041165
setupStore13599141040
numNetworkReqs1156516759
BrowserifyPower User HomeuiStartup26752090479142828103495
load12161045170614512411549
domContentLoaded12161038170614512411548
domInteractive13336622107134442
firstPaint------
backgroundConnect177341031197185676
firstReactRender65372372668110
getState32482991240469833
initialActions217126
loadScripts11661000160212911991509
setupStore16715807208166754
numNetworkReqs92623055080224
WebpackStandard HomeuiStartup14801235211615815311815
load12331067155710513021431
domContentLoaded12321067155710413021431
domInteractive56272463581111
firstPaint------
backgroundConnect46171612645113
firstReactRender26207582739
getState156175211328
initialActions102122
loadScripts1203104914969912711403
setupStore165109201374
numNetworkReqs1256717762
WebpackPower User HomeuiStartup30282097567181529184899
load15411162295046415962761
domContentLoaded15401161294946415962761
domInteractive11531477102108377
firstPaint------
backgroundConnect2262015323221641146
firstReactRender65402232965136
getState28974877217398828
initialActions217123
loadScripts14311143280232615362263
setupStore14961146207132607
numNetworkReqs91603304198175
📊 Page Load Benchmark Results

Current Commit: 5df6cdb | Date: 12/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±63ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 733ms (±75ms) 🟢 | historical mean value: 729ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 89ms (±130ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 63ms 1.01s 1.41s 1.13s 1.41s
domContentLoaded 733ms 75ms 696ms 1.32s 777ms 1.32s
firstPaint 89ms 130ms 60ms 1.38s 88ms 1.38s
firstContentfulPaint 89ms 130ms 60ms 1.38s 88ms 1.38s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: -56 Bytes (0%)
  • common: 62 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lwin-kyaw lwin-kyaw lwin-kyaw left review comments

@chaitanyapotti chaitanyapotti Awaiting requested review from chaitanyapotti

@lionellbriones lionellbriones Awaiting requested review from lionellbriones

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

area-shield size-XS team-shield Shield team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tuna1207 @metamaskbot @lwin-kyaw