Skip to content

feat: default shield env to main using dev local build #38522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tuna1207 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

feat: default shield env to main using dev local build #38522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions shared/modules/shield/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,10 @@ export const ShieldConfigMap: Record<BuildType, ShieldEnvConfig> = {
},
};

export function isTestEnvironment() {
return process.env.METAMASK_ENVIRONMENT === ENVIRONMENT.TESTING;
}

/**
* Check if the environment is a Development or Test environment.
*
Expand All @@ -91,7 +95,7 @@ export const ShieldConfigMap: Record<BuildType, ShieldEnvConfig> = {
export function isDevOrTestEnvironment() {
return (
process.env.METAMASK_ENVIRONMENT === ENVIRONMENT.DEVELOPMENT ||
process.env.METAMASK_ENVIRONMENT === ENVIRONMENT.TESTING
isTestEnvironment()
);
}

Expand All @@ -116,7 +120,7 @@ export function loadShieldConfig(): ShieldEnvConfig {
const buildType = process.env.METAMASK_BUILD_TYPE;

let buildTypeEnv: BuildType = BUILD_TYPE.main;
if (isDevOrTestEnvironment()) {
if (isTestEnvironment()) {
Copy link
Contributor

@lwin-kyaw lwin-kyaw Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local dev build with yarn start is pointing to prod env. Is it expected?

Copy link
Member Author

@tuna1207 tuna1207 Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's the purpose of this PR, so it match local dev default for profile sync controller (also prod env)

buildTypeEnv = BUILD_TYPE.dev;
} else if (buildType === 'experimental') {
buildTypeEnv = BUILD_TYPE.experimental;
Expand Down
Loading