fix: list item disappearing in token page cp-13.20.0#40316
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (1 files, +14 -2)
|
Contributor
Builds ready [94829dd]
⚡ Performance Benchmarks (1359 ± 108 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
AndyMBridges
approved these changes
Feb 23, 2026
ui/components/app/transaction-list/unified-transaction-list.component.js
Show resolved
Hide resolved
Contributor
Builds ready [d772d9a]
⚡ Performance Benchmarks (1370 ± 112 ms)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
ameliejyc
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix for the activity list items disappearing too early on scroll in the token details screen
Changelog
CHANGELOG entry: fix: list item disappearing in token page
Related issues
Fixes: #40097
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Small UI-only change to list virtualization math; main risk is minor layout/scroll regressions in the activity list.
Overview
Fixes a virtualization offset bug in
UnifiedTransactionListthat caused transaction rows to disappear too early while scrolling on token detail pages.The list now measures its own
offsetTopand passes it asscrollMarginto@tanstack/react-virtual, adjusting each row’stranslateYto account for the scroll container’s margin.Written by Cursor Bugbot for commit d772d9a. This will update automatically on new commits. Configure here.