Skip to content

Comments

fix: list item disappearing in token page cp-13.20.0#40316

Merged
n3ps merged 2 commits intomainfrom
n3ps/fix-asset-activity-simple
Feb 23, 2026
Merged

fix: list item disappearing in token page cp-13.20.0#40316
n3ps merged 2 commits intomainfrom
n3ps/fix-asset-activity-simple

Conversation

@n3ps
Copy link
Contributor

@n3ps n3ps commented Feb 22, 2026

Description

Fix for the activity list items disappearing too early on scroll in the token details screen

Open in GitHub Codespaces

Changelog

CHANGELOG entry: fix: list item disappearing in token page

Related issues

Fixes: #40097

Manual testing steps

  1. Go to a token page with activity
  2. Scroll down

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Small UI-only change to list virtualization math; main risk is minor layout/scroll regressions in the activity list.

Overview
Fixes a virtualization offset bug in UnifiedTransactionList that caused transaction rows to disappear too early while scrolling on token detail pages.

The list now measures its own offsetTop and passes it as scrollMargin to @tanstack/react-virtual, adjusting each row’s translateY to account for the scroll container’s margin.

Written by Cursor Bugbot for commit d772d9a. This will update automatically on new commits. Configure here.

@n3ps n3ps added the team-core-extension-ux Core Extension UX team label Feb 22, 2026
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@n3ps n3ps marked this pull request as ready for review February 22, 2026 04:01
@n3ps n3ps requested a review from a team as a code owner February 22, 2026 04:01
@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Feb 22, 2026

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (1 files, +14 -2)
  • 📁 ui/
    • 📁 components/
      • 📁 app/
        • 📁 transaction-list/
          • 📄 unified-transaction-list.component.js +14 -2

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Feb 22, 2026

Builds ready [94829dd]
⚡ Performance Benchmarks (1359 ± 108 ms)
👆 Interaction Benchmarks
ActionMetricMean (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account2988301307
total2988301307
Confirm Txconfirm_tx6026960316037
total6026960316037
Bridge User Actionsbridge_load_page24736271283
bridge_load_asset_picker23926238278
bridge_search_token7193723723
total12052712071248
🔌 Startup Benchmarks
BuildMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
Chrome Browserify Startup Standard HomeuiStartup13591165184610814051519
load115796715659011881312
domContentLoaded115096315408711821291
domInteractive2816106202476
firstPaint1586647079203336
backgroundConnect20218525213205230
firstReactRender18134241925
initialActions107112
loadScripts96477813438710001110
setupStore1364361525
numNetworkReqs312298192282
Chrome Browserify Startup Power User HomeuiStartup16761370224315217071988
load1105988163413410981470
domContentLoaded1092978162513210871444
domInteractive3418173273171
firstPaint177731257137223319
backgroundConnect27424332317284306
firstReactRender23144572540
initialActions102111
loadScripts89578614251328831254
setupStore1665091937
numNetworkReqs58361522555121
Chrome Webpack Startup Standard HomeuiStartup8737061163989161069
load74262793389797899
domContentLoaded73662292888790894
domInteractive2916106212488
firstPaint1246375090166239
backgroundConnect26184563038
firstReactRender19113962131
initialActions105112
loadScripts73362092687788886
setupStore1253541319
numNetworkReqs312299202587
Chrome Webpack Startup Power User HomeuiStartup1182856193314512731432
load7036221195106697980
domContentLoaded6946171187105683969
domInteractive34181282632113
firstPaint1346453176154267
backgroundConnect16913031044160274
firstReactRender22153842429
initialActions104111
loadScripts6916151179103681957
setupStore1344371432
numNetworkReqs1063426451135228
Firefox Browserify Startup Standard HomeuiStartup16901410275124016862163
load14301177254321014381768
domContentLoaded14291177253621014381768
domInteractive109361069137136184
firstPaint------
backgroundConnect64283434261128
firstReactRender13102021417
initialActions103122
loadScripts13981154252620114141647
setupStore218170281645
numNetworkReqs3220101212790
Firefox Browserify Startup Power User HomeuiStartup28892223391937530463638
load16901395249924417712212
domContentLoaded16891395249924417712211
domInteractive13038659117127421
firstPaint------
backgroundConnect2771181005220256913
firstReactRender21166862126
initialActions214122
loadScripts16441376243522317202133
setupStore1809758227248682
numNetworkReqs59281633786141
Firefox Webpack Startup Standard HomeuiStartup16951393330132316702022
load14391188300930214351586
domContentLoaded14381188300930214311586
domInteractive96281491148128164
firstPaint------
backgroundConnect59253294261124
firstReactRender15124851524
initialActions103112
loadScripts14141175297029914111555
setupStore177168261245
numNetworkReqs311994192577
Firefox Webpack Startup Power User HomeuiStartup26171983361438226863451
load15431227237426516512243
domContentLoaded15431227237426516512243
domInteractive11734651118107438
firstPaint------
backgroundConnect207102814135215525
firstReactRender21155852329
initialActions203122
loadScripts15031211235824416181938
setupStore16991061222218638
numNetworkReqs56281463482127
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2193222223
srpButtonToSrpForm9319495
confirmSrpToPwForm2102121
pwFormToMetricsScreen1501515
metricsToWalletReadyScreen1601616
doneButtonToHomeScreen105630413311505
openAccountMenuToAccountListLoaded731022274447657
total873033689349080
Onboarding New WalletcreateWalletToSocialScreen2170218218
srpButtonToPwForm1041104105
createPwToRecoveryScreen8088
skipBackupToMetricsScreen3313435
agreeButtonToOnboardingSuccess1611616
doneButtonToAssetList58824620620
total938579601006
Asset DetailsassetClickToPriceChart48125767
total48125767
Solana Asset DetailsassetClickToPriceChart4504545
total4504545
Import Srp HomeloginToHomeScreen22126422232311
openAccountMenuAfterLogin3844243
homeAfterImportWithNewWallet269715228462847
total48007148544854
Send TransactionsopenSendPageFromHome34175356
selectTokenToSendFormLoaded3073341
reviewTransactionToConfirmationPage105214311851254
total111614912321341
SwapopenSwapPageFromHome13327155162
fetchAndDisplaySwapQuotes532184962896430
total545486464516569
🌐 Dapp Page Load Benchmarks

Current Commit: 94829dd | Date: 2/22/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±39ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 724ms (±36ms) 🟢 | historical mean value: 726ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±12ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 39ms 1.02s 1.32s 1.09s 1.32s
domContentLoaded 724ms 36ms 704ms 990ms 763ms 990ms
firstPaint 77ms 12ms 60ms 176ms 84ms 176ms
firstContentfulPaint 77ms 12ms 60ms 176ms 84ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: 125 Bytes (0%)
  • common: 20 Bytes (0%)

@n3ps n3ps changed the title fix: list item disappearing in token page fix: list item disappearing in token page cp-13.20.0 Feb 22, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Feb 23, 2026

Builds ready [d772d9a]
⚡ Performance Benchmarks (1370 ± 112 ms)
👆 Interaction Benchmarks
ActionMetricMean (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account29920313320
total29920313320
Confirm Txconfirm_tx60731660826093
total60731660826093
Bridge User Actionsbridge_load_page2084208214
bridge_load_asset_picker20114214218
bridge_search_token7084708714
total1127211291129
🔌 Startup Benchmarks
BuildMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
Chrome Browserify Startup Standard HomeuiStartup13701188192211213831596
load115597815509511751343
domContentLoaded114997315399411691332
domInteractive2616115182372
firstPaint164661190159204298
backgroundConnect20018425013200231
firstReactRender19133752028
initialActions105113
loadScripts9657921353939841148
setupStore1364861622
numNetworkReqs312291192484
Chrome Browserify Startup Power User HomeuiStartup3049143910699209539398781
load12341047172413112891528
domContentLoaded12161030171512712631517
domInteractive3520194283265
firstPaint223841168132280353
backgroundConnect13092668100185620666880
firstReactRender24164852635
initialActions102111
loadScripts1006834148112210411279
setupStore1564261726
numNetworkReqs81411392194122
Chrome Webpack Startup Standard HomeuiStartup86968413321109261078
load733609107695813883
domContentLoaded728604107094805873
domInteractive2814128222488
firstPaint1175941769146227
backgroundConnect27187993041
firstReactRender19124262131
initialActions105114
loadScripts725602106193803865
setupStore1253661224
numNetworkReqs312295202588
Chrome Webpack Startup Power User HomeuiStartup1242843207718713221573
load7426361166103733990
domContentLoaded7306271150103723982
domInteractive43211573141126
firstPaint1587050578188303
backgroundConnect18113085781170285
firstReactRender22173432427
initialActions102011
loadScripts7286251142101721974
setupStore1343861622
numNetworkReqs1314724438154203
Firefox Browserify Startup Standard HomeuiStartup16871430255420517022134
load14201212228215314531717
domContentLoaded14181206228215314531716
domInteractive913390495101150
firstPaint------
backgroundConnect62322293259122
firstReactRender14112321518
initialActions102122
loadScripts13911182225614714291675
setupStore178136201534
numNetworkReqs312098202789
Firefox Browserify Startup Power User HomeuiStartup29232300793758330303424
load16851341661454717972102
domContentLoaded16841341661354617972102
domInteractive16857753129169462
firstPaint------
backgroundConnect4411251368276645935
firstReactRender18157161823
initialActions203122
loadScripts16351313657054317222073
setupStore12312697139129445
numNetworkReqs883122442100177
Firefox Webpack Startup Standard HomeuiStartup17171490322919817511997
load14471242287616714911584
domContentLoaded14471241287516714901583
domInteractive1013028851131192
firstPaint------
backgroundConnect61262873561118
firstReactRender16123141625
initialActions103122
loadScripts14231219283816414701559
setupStore257159321693
numNetworkReqs302093152766
Firefox Webpack Startup Power User HomeuiStartup29132054904088030273487
load17331368731779916612279
domContentLoaded17321368731679916612278
domInteractive17345881159193528
firstPaint------
backgroundConnect4458013813126071129
firstReactRender231670102434
initialActions204122
loadScripts16881345726879816272255
setupStore15318762183189609
numNetworkReqs84312143984190
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2180218218
srpButtonToSrpForm9119293
confirmSrpToPwForm2212223
pwFormToMetricsScreen1611617
metricsToWalletReadyScreen1701717
doneButtonToHomeScreen11199011441249
openAccountMenuToAccountListLoaded73949774647464
total88693489118911
Onboarding New WalletcreateWalletToSocialScreen2191220220
srpButtonToPwForm1125117120
createPwToRecoveryScreen9099
skipBackupToMetricsScreen3703738
agreeButtonToOnboardingSuccess1611717
doneButtonToAssetList630153727881
total102514911131273
Asset DetailsassetClickToPriceChart52176978
total52176978
Solana Asset DetailsassetClickToPriceChart4614648
total4614648
Import Srp HomeloginToHomeScreen20109320682162
openAccountMenuAfterLogin4434448
homeAfterImportWithNewWallet24281924512451
total44595744774543
Send TransactionsopenSendPageFromHome32103941
selectTokenToSendFormLoaded1922121
reviewTransactionToConfirmationPage8535856860
total90313907922
SwapopenSwapPageFromHome12413132139
fetchAndDisplaySwapQuotes45862045784620
total47122947164752
🌐 Dapp Page Load Benchmarks

Current Commit: d772d9a | Date: 2/23/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±44ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 738ms (±43ms) 🟢 | historical mean value: 727ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 79ms (±13ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 44ms 1.03s 1.42s 1.09s 1.42s
domContentLoaded 738ms 43ms 715ms 1.09s 758ms 1.09s
firstPaint 79ms 13ms 64ms 192ms 88ms 192ms
firstContentfulPaint 79ms 13ms 64ms 192ms 88ms 192ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: 125 Bytes (0%)
  • common: 20 Bytes (0%)

@n3ps n3ps added this pull request to the merge queue Feb 23, 2026
Merged via the queue into main with commit 5ed3d6b Feb 23, 2026
177 checks passed
@n3ps n3ps deleted the n3ps/fix-asset-activity-simple branch February 23, 2026 16:22
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2026
@metamaskbot metamaskbot added the release-13.21.0 Issue or pull request that will be included in release 13.21.0 label Feb 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.21.0 Issue or pull request that will be included in release 13.21.0 size-S team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Activity list in asset details page shows a blank component on top of the list

4 participants