Skip to content

fix: list item disappearing in token page cp-13.20.0 #40316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n3ps merged 2 commits into from
Feb 23, 2026
+14 −2
Merged

fix: list item disappearing in token page cp-13.20.0 #40316

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94829dd
fix: list item disappearing
n3ps Feb 22, 2026
d772d9a
Merge branch 'main' into n3ps/fix-asset-activity-simple
n3ps Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions ui/components/app/transaction-list/unified-transaction-list.component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,13 +909,22 @@ export default function UnifiedTransactionList({
return flattened;
}, [processedUnifiedActivityItems]);

const [scrollMargin, setScrollMargin] = useState(0);

const listRef = useCallback((node) => {
if (node) {
setScrollMargin(node.offsetTop);
}
}, []);

const virtualizer = useVirtualizer({
count: items.length,
getScrollElement: () => scrollContainerRef?.current || null,
estimateSize: (index) =>
items[index]?.type === 'date-header' ? HEADER_HEIGHT : ITEM_HEIGHT,
overscan: 10,
initialOffset: scrollContainerRef?.current?.scrollTop,
scrollMargin,
});

return (
Expand Down Expand Up @@ -950,21 +959,24 @@ export default function UnifiedTransactionList({
<TransactionActivityEmptyState className="mx-auto mt-5 mb-6" />
) : (
<div
ref={listRef}
className="transaction-list__transactions relative w-full"
style={{
height: `${virtualizer.getTotalSize()}px`,
}}
>
{virtualizer.getVirtualItems().map((virtualItem) => {
const item = items[virtualItem.index];
const translateY =
virtualItem.start - virtualizer.options.scrollMargin;

if (item.type === 'date-header') {
return (
<div
key={`date-${item.date}`}
className="absolute top-0 left-0 w-full"
style={{
transform: `translateY(${virtualItem.start}px)`,
transform: `translateY(${translateY}px)`,
}}
>
<Text
Expand All @@ -986,7 +998,7 @@ export default function UnifiedTransactionList({
ref={virtualizer.measureElement}
className="absolute top-0 left-0 w-full"
style={{
transform: `translateY(${virtualItem.start}px)`,
transform: `translateY(${translateY}px)`,
}}
>
{renderTransaction(item.data, virtualItem.index)}
Expand Down
Loading