fix(WeakRefObjectMap): make delete consistent with has for dead entries#40509
Draft
Copilot wants to merge 2 commits intoweakref-object-map-main-firstfrom
Draft
fix(WeakRefObjectMap): make delete consistent with has for dead entries#40509Copilot wants to merge 2 commits intoweakref-object-map-main-firstfrom
delete consistent with has for dead entries#40509Copilot wants to merge 2 commits intoweakref-object-map-main-firstfrom
Conversation
7 tasks
Co-authored-by: MajorLift <34228073+MajorLift@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix memory leak issue in WeakRefObjectMap
fix(WeakRefObjectMap): make Feb 28, 2026
delete consistent with has for dead entries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deletedelegated directly tothis.map.delete(key), bypassing liveness checks, so it returnedtruefor GC'd entries whilehasreturnedfalsefor the same key. All existing tests masked this because they calledhas/getfirst, which pruned dead entries beforedeleteran.Changes
WeakRefObjectMap.ts: Usethis.has(key)(the public method, which runsisLiveOrDelete) before delegating to the internal map:Dead entries now return
falsefrom bothhasanddelete(and are pruned bydeleteitself). Behavior is unchanged for live entries and non-existent keys.WeakRefObjectMap.test.ts: Added a test that callsdeletedirectly on a dead entry without any priorhas/getcall, covering the previously-undetected inconsistency.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.