feat: use compressed deep link on Metamask Mobile Demo #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| console.log("Compressed deep link length:", compressedDeepLinkUrl.length); | ||
|
|
||
| setQrCodeData(deepLinkUrl); | ||
| setQrCodeData(compressedDeepLinkUrl); |
There was a problem hiding this comment.
Bug: QR Code Log Message Incorrect
The log message for QR code generation at line 252 incorrectly states that a "base64 encoded deep link" is used. The QR code is now generated with a compressed deep link, making the current log message misleading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to use deeplink compression logic to decrease size of transported payloads across established connections.
Checklist
Issue
Resolves https://www.notion.so/metamask-consensys/SDK-Phase-1-End-game-276f86d67d688061a461ee0cbaf37649?p=278f86d67d6880c0a460f671085afbea&pm=s
Note
Switch QR code to a compressed deep link and URI-encode the compressed payload parameter.
compressString(jsonPayload)->encodeURIComponent(compressString(jsonPayload)).metamask://connect/mwp?p=...&c=1) for the QR code instead of the standard link.Written by Cursor Bugbot for commit 677bcbc. This will update automatically on new commits. Configure here.