Skip to content

feat: use compressed deep link on Metamask Mobile Demo #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ffmcgee725 merged 3 commits into from
Oct 8, 2025
Merged

feat: use compressed deep link on Metamask Mobile Demo #54

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
642a6cf
feat: use compressed deep link
ffmcgee725 Oct 8, 2025
f24c767
minor fix
ffmcgee725 Oct 8, 2025
677bcbc
minor fix
ffmcgee725 Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/web-demo/src/components/MetaMaskMobileDemo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,13 +242,13 @@ export default function MetaMaskMobileDemo() {
const deepLinkUrl = `metamask://connect/mwp?p=${uriEncodedPayload}`;

// Also show what the compressed URL would look like
const compressedPayload = compressString(jsonPayload);
const compressedPayload = encodeURIComponent(compressString(jsonPayload));
const compressedDeepLinkUrl = `metamask://connect/mwp?p=${compressedPayload}&c=1`; // c=1 indicates compressed

console.log("Standard deep link length:", deepLinkUrl.length);
console.log("Compressed deep link length:", compressedDeepLinkUrl.length);

setQrCodeData(deepLinkUrl);
setQrCodeData(compressedDeepLinkUrl);
Copy link

@cursor cursor bot Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: QR Code Log Message Incorrect

The log message for QR code generation at line 252 incorrectly states that a "base64 encoded deep link" is used. The QR code is now generated with a compressed deep link, making the current log message misleading.

Fix in Cursor Fix in Web

addDappLog("system", "QR code generated with base64 encoded deep link. Ready for wallet to scan.");

// Start session timer
Expand Down