feat: scan for npx usage in package.json and shell scripts #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds a semgrep rule that flags usage of
npxto install dependencies. Instead, it suggests installing the dependency to the project, and invoking it using the project's package manager. At this point in time, we are not intending to flag npx usage found in README files to focus developer efforts on the highest priority items (npx usage in code).For reviewers
To rest this rule against a local repo or file, check out this branch and run the following:
Please let me know if there are any other test cases or scenarios that I am missing in the semgrep tests. These tests can be run by executing
./bin/testVisit this page for a reminder regarding how these rules get rendered in GitHub's UI.