-
Notifications
You must be signed in to change notification settings - Fork 637
chore: make @metamask/test-snaps-site publishable #3679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3679 +/- ##
=======================================
Coverage 98.29% 98.29%
=======================================
Files 417 417
Lines 11924 11924
Branches 1851 1851
=======================================
Hits 11721 11721
Misses 203 203 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@seaona The output from snaps/packages/snaps-cli/package.json Line 20 in 9aa68cd
package.json. You can run yarn constraints yourself to see.)
|
| "lint:eslint": "eslint . --cache", | ||
| "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write", | ||
| "lint:misc": "prettier --no-error-on-unmatched-pattern --log-level warn \"**/*.json\" \"**/*.md\" \"**/*.html\" \"!CHANGELOG.md\" --ignore-path ../../.gitignore", | ||
| "publish:preview": "yarn npm publish --tag preview", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| !isExample && | ||
| workspace.cwd !== 'packages/snaps-sandbox' | ||
| workspace.cwd !== 'packages/snaps-sandbox' && | ||
| workspace.cwd !== 'packages/test-snaps' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
hi there @mcmire thank you for taking a look! I think issues should be fixed now 🙏 |
…publishing (#3712) Following #3679, we want `test-snaps` to be publishable to NPM. Currently only TypeScript packages are built, so `test-snaps` wouldn't be published properly. I've added an extra step to build `test-snaps` before running the NPM publish job. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Updates the publish-release workflow to install dependencies in a dedicated step and build `@metamask/test-snaps` so it’s included in release artifacts/NPM publish. > > - **CI (GitHub Actions)**: > - **`publish-release` job**: > - Add dedicated `Install dependencies` step (`yarn install --immutable`). > - Build all packages with `yarn build`. > - New step to build `@metamask/test-snaps` (`yarn workspace @metamask/test-snaps build`) so artifacts include it. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 4ffbc25. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->


Note
Make
@metamask/test-snapspublishable and adjust Yarn constraints accordingly.privateand addingpublishConfig(access: public, npm registry).distviafilesarray.scripts.publish:preview.packages/test-snapsfrom ESM/CJS exports enforcement (same assnaps-sandbox).Written by Cursor Bugbot for commit 6efe9dd. This will update automatically on new commits. Configure here.