fix: Recreate JSON-RPC request in MultichainRouter#3086
Merged
FrederikBolding merged 2 commits intomainfrom Feb 12, 2025
Merged
fix: Recreate JSON-RPC request in MultichainRouter#3086FrederikBolding merged 2 commits intomainfrom
FrederikBolding merged 2 commits intomainfrom
Conversation
Mrtenz
approved these changes
Feb 12, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3086 +/- ##
=======================================
Coverage 94.88% 94.88%
=======================================
Files 506 506
Lines 11120 11123 +3
Branches 1708 1709 +1
=======================================
+ Hits 10551 10554 +3
Misses 569 569 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreate the JSON-RPC request in MultichainRouter to remove any unnecesary properties passed in from the middlewares in the client. This ensures that we don't leak unnecessary details to Snaps and also makes sure the requests are formatted as expected downstream.