Skip to content

fix: Recreate JSON-RPC request in MultichainRouter #3086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrederikBolding merged 2 commits into from
Feb 12, 2025
Merged

fix: Recreate JSON-RPC request in MultichainRouter #3086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a218de7
fix: Recreate JSON-RPC request in MultichainRouter
FrederikBolding Feb 12, 2025
644f55e
Update coverage
FrederikBolding Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/snaps-controllers/coverage.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"branches": 93.28,
"branches": 93.31,
"functions": 96.8,
"lines": 98.15,
"statements": 97.88
Expand Down
11 changes: 10 additions & 1 deletion packages/snaps-controllers/src/multichain/MultichainRouter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import {
KnownCaipNamespace,
parseCaipAccountId,
} from '@metamask/utils';
import { nanoid } from 'nanoid';

import { getRunnableSnaps } from '../snaps';
import type { GetAllSnaps, HandleSnapRequest } from '../snaps';
Expand Down Expand Up @@ -291,7 +292,7 @@ export class MultichainRouter {
connectedAddresses,
origin,
scope,
request,
request: rawRequest,
}: {
connectedAddresses: CaipAccountId[];
origin: string;
Expand All @@ -304,6 +305,14 @@ export class MultichainRouter {
!scope.startsWith('wallet:eip155'),
);

// Re-create the request to simplify and remove additional properties that may be present in MM middleware.
const request = {
jsonrpc: '2.0' as const,
id: rawRequest.id ?? nanoid(),
method: rawRequest.method,
params: rawRequest.params,
};

const { method, params } = request;

// If the RPC request can be serviced by an account Snap, route it there.
Expand Down
Loading