feat: Button

[ghost]

Description of change

Built button component variants

Issue Number

closes #128

Type of change

• New (a change which implements a new feature)
• Update (a change which updates existing functionality)

How the change has been tested

CI and Manual

Change checklist

• I have ensured that the CI Checks pass locally
• I have removed any unnecessary logic
• My code is well documented
• I have signed my commits
• My code follows the pattern of the application
• I have self reviewed my code

Summary by CodeRabbit

• New Features

  • Introduced a new "secondary" variant for buttons, offering additional styling options.
  • Added a story to showcase the new "secondary" button variant with blocking click behavior.

• Style

  • Expanded the color palette with new burnt orange theme variables for enhanced UI customization.
  • Slightly adjusted the gray shade in the theme for improved visual consistency.

[coderabbitai]

"""

Walkthrough

The Button component was updated to replace the 'danger' variant with a new 'secondary' variant, including changes to props, styles, and story definitions. The CSS theme was extended with a detailed palette of burnt orange shades and a slight adjustment to a gray shade.

Changes

File(s)	Change Summary
platforms/metagram/src/app.css	Updated --color-black-400 value; added --color-brand-burnt-orange variables (100–900) with a gradient.
platforms/metagram/src/lib/ui/Button/Button.svelte	Changed variant prop type from 'danger' to 'secondary'; updated variant classes and added border styling.
platforms/metagram/src/lib/ui/Button/Button.stories.ts	Renamed Danger story to Secondary; updated args to use 'secondary' variant with blockingClick and async callback.

Sequence Diagram(s)

sequenceDiagram
    participant Storybook
    participant ButtonComponent
    participant User

    Storybook->>ButtonComponent: Render with variant='secondary'
    User->>ButtonComponent: Clicks button
    ButtonComponent->>ButtonComponent: Apply blockingClick logic
    ButtonComponent->>User: Shows ButtonText
    ButtonComponent->>ButtonComponent: Waits for async callback (2s)
    ButtonComponent->>User: Unblocks after callback

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Add a Button component with multiple variants (e.g., primary, secondary) (#128)	✅

Poem

A button now dons a coat anew,
In shades of orange, gray, and blue.
With borders crisp and stories bright,
The 'secondary' shines in UI light.
Colors and clicks, a rabbit’s delight—
Code hops ahead, all through the night!
🐇✨
"""

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

platforms/metagram/src/lib/ui/Button/Button.svelte (1)

107-132: Update component documentation

The component documentation comments should be updated to include the new 'secondary' variant in the variant description.

- - variant: The variant of the button. Default is `primary`.
+ - variant: The variant of the button. Can be 'primary', 'secondary', or 'danger'. Default is `primary`.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3ad2c15 and d408fc1.

📒 Files selected for processing (3)

• platforms/metagram/src/app.css (1 hunks)
• platforms/metagram/src/lib/ui/Button/Button.stories.ts (1 hunks)
• platforms/metagram/src/lib/ui/Button/Button.svelte (4 hunks)

🧰 Additional context used

🪛 Biome (1.9.4)

platforms/metagram/src/app.css

[error] 47-47: expected , but instead found ;

Remove ;

(parse)

---

[error] 48-48: expected , but instead found --color-brand-burnt-orange-200

Remove --color-brand-burnt-orange-200

(parse)

---

[error] 48-48: Unexpected value or character.

Expected one of:

(parse)

---

[error] 48-48: expected , but instead found ;

Remove ;

(parse)

---

[error] 49-49: expected , but instead found --color-brand-burnt-orange-300

Remove --color-brand-burnt-orange-300

(parse)

---

[error] 49-49: Unexpected value or character.

Expected one of:

(parse)

---

[error] 49-49: expected , but instead found ;

Remove ;

(parse)

---

[error] 50-50: expected , but instead found --color-brand-burnt-orange-400

Remove --color-brand-burnt-orange-400

(parse)

---

[error] 50-50: Unexpected value or character.

Expected one of:

(parse)

---

[error] 50-50: expected , but instead found ;

Remove ;

(parse)

---

[error] 51-51: expected , but instead found --color-brand-burnt-orange-500

Remove --color-brand-burnt-orange-500

(parse)

---

[error] 51-51: Unexpected value or character.

Expected one of:

(parse)

---

[error] 51-51: expected , but instead found ;

Remove ;

(parse)

---

[error] 52-52: expected , but instead found --color-brand-burnt-orange-600

Remove --color-brand-burnt-orange-600

(parse)

---

[error] 52-52: Unexpected value or character.

Expected one of:

(parse)

---

[error] 52-52: Expected an identifier but instead found '91310'.

Expected an identifier here.

(parse)

---

[error] 52-52: expected , but instead found B

Remove B

(parse)

---

[error] 52-52: expected , but instead found ;

Remove ;

(parse)

---

[error] 53-53: expected , but instead found --color-brand-burnt-orange-700

Remove --color-brand-burnt-orange-700

(parse)

---

[error] 53-53: Unexpected value or character.

Expected one of:

(parse)

---

[error] 53-53: Expected an identifier but instead found '6'.

Expected an identifier here.

(parse)

---

[error] 53-53: expected , but instead found D2509

Remove D2509

(parse)

---

[error] 53-53: expected , but instead found ;

Remove ;

(parse)

---

[error] 54-54: expected , but instead found --color-brand-burnt-orange-800

Remove --color-brand-burnt-orange-800

(parse)

---

[error] 54-54: Unexpected value or character.

Expected one of:

(parse)

---

[error] 54-54: Expected an identifier but instead found '491906'.

Expected an identifier here.

(parse)

---

[error] 55-55: expected , but instead found --color-brand-burnt-orange-900

Remove --color-brand-burnt-orange-900

(parse)

---

[error] 55-55: Unexpected value or character.

Expected one of:

(parse)

---

[error] 55-55: Expected an identifier but instead found '2'.

Expected an identifier here.

(parse)

---

[error] 55-55: expected , but instead found C0F03

Remove C0F03

(parse)

---

[error] 55-55: expected , but instead found ;

Remove ;

(parse)

🔇 Additional comments (6)

platforms/metagram/src/lib/ui/Button/Button.stories.ts (1)

19-28: LGTM! Good implementation of the Secondary button story

The Secondary story follows the established pattern of the other stories, correctly implementing the new button variant with blocking click functionality.

platforms/metagram/src/lib/ui/Button/Button.svelte (5)

6-6: LGTM! Properly extended the type definition

The variant type has been extended to include the new 'secondary' option.

---

42-44: LGTM! Good implementation of variant classes

The variant classes for the new secondary button are properly implemented, and the primary button now has a border style.

---

48-50: LGTM! Properly defined disabled styles

The disabled style for the secondary variant is correctly implemented with reduced opacity.

---

69-71: LGTM! Proper border handling added

The border class is now conditionally applied based on the button's disabled state and variant.

---

83-83: LGTM! Border class properly applied

The border class is correctly added to the button's class list.

[coderabbitai]

Actionable comments posted: 1

♻️ Duplicate comments (1)

platforms/metagram/src/lib/ui/Button/Button.svelte (1)

43-43: Check CSS naming inconsistency

The class bg-grey is still using the British spelling, while previous review comments indicated there was an issue with grey vs gray spelling in your CSS system.

#!/bin/bash
# Check if grey vs gray is consistently used in CSS variables and classes
echo "Checking for gray vs grey naming patterns in the codebase..."
rg --type css "color-gr[ae]y" --glob "!*.md"
echo "Searching for bg-grey usage..."
rg "bg-gr[ae]y" --type svelte --type css

🧹 Nitpick comments (1)

platforms/metagram/src/lib/ui/Button/Button.svelte (1)

125-137: Update component documentation

The component documentation still references features not shown in the implementation (like an icon slot mentioned on line 133). Additionally, it should be updated to reflect the change from 'danger' to 'secondary' variant.

Consider updating the component documentation to accurately reflect the current implementation and available variants.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d408fc1 and 2ccd984.

📒 Files selected for processing (3)

• platforms/metagram/src/app.css (1 hunks)
• platforms/metagram/src/lib/ui/Button/Button.stories.ts (1 hunks)
• platforms/metagram/src/lib/ui/Button/Button.svelte (4 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• platforms/metagram/src/lib/ui/Button/Button.stories.ts
• platforms/metagram/src/app.css

🔇 Additional comments (4)

platforms/metagram/src/lib/ui/Button/Button.svelte (4)

42-51: Updated variant styling with brand colors

The replacement of 'danger' with 'secondary' using the new burnt orange color palette looks good. The border styles have been added consistently for both variants.

---

55-64: Disabled state styling is consistent with variant changes

The disabled styling for both primary and secondary variants looks good, applying 50% opacity consistently across background, text, and border.

---

83-85: Border handling added to derived classes

Good addition of border styling to the derived classes object, ensuring border styles are properly applied based on the button's state.

---

97-97: Added border class to button element

Correctly applied the border class to the button element to ensure the border styling is visible.

[coderabbitai]

💡 Verification agent

🧩 Analysis chain

Variant name changed from 'danger' to 'secondary'

This is a breaking change that will require updates in all places where the Button component is used with the 'danger' variant. Make sure all consuming components have been updated accordingly.

---

🏁 Script executed:

#!/bin/bash
# Search for any remaining usages of the 'danger' variant in the codebase
echo "Searching for places where the Button component is used with danger variant..."
rg "variant\s*=\s*['\"]danger['\"]" --type svelte --type ts --type jsx --type tsx

Length of output: 285

---

Let's re-run the search across all relevant file extensions without relying on missing type definitions:

---

🏁 Script executed:

#!/bin/bash
echo "Searching for any remaining `danger` variant usages..."
rg --glob '*.svelte' --glob '*.ts' --glob '*.tsx' --glob '*.jsx' "variant\s*=\s*['\"]danger['\"]"

Length of output: 570

---

Update remaining ‘danger’ variants to ‘secondary’

We’ve identified two leftover usages of the now-removed danger variant. Please update these to variant="secondary" (or adjust as needed for your design system):

• infrastructure/eid-wallet/src/routes/+page.svelte
<Button.Action class="w-full" variant="danger" callback={clearPin}>

• infrastructure/eid-wallet/src/routes/(auth)/login/+page.svelte
<Button.Action class="w-full" variant="danger" callback={clearPin}>

After making these changes, rerun a search for variant="danger" to ensure no breaks remain.

[Sahil2004]

LGTM.