Skip to content

Conversation

ghost
Copy link

@ghost ghost commented May 13, 2025

Description of change

Built BottomNav
image

Issue Number

closes #126

Type of change

  • New (a change which implements a new feature)
  • Update (a change which updates existing functionality)

How the change has been tested

CI and Manual

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • New Features

    • Introduced a bottom navigation bar with five tabs (home, discover, post, messages, profile) for protected routes.
    • Added new icon components (Search, Camera) and updated existing icons for improved customization.
    • Implemented new protected pages: Home, Discover, Post, Messages, and Profile.
    • Added smooth directional slide and fade transitions between pages for enhanced navigation experience.
    • Navigation state is now tracked to differentiate between navigation types.
  • Bug Fixes

    • Improved icon rendering for better consistency and appearance.
  • Documentation

    • Added Storybook story for the BottomNav component to facilitate UI documentation and testing.

@ghost ghost requested a review from coodos as a code owner May 13, 2025 07:47
Copy link
Contributor

coderabbitai bot commented May 13, 2025

Walkthrough

This update introduces a bottom navigation bar with animated transitions for a SvelteKit application. It adds new icon components, a bottom navigation fragment, related Storybook stories, and protected route layouts/pages. The code implements animated view transitions using CSS and navigation state management, ensuring the bottom navigation bar appears and functions as intended across protected routes.

Changes

File(s) Change Summary
.../src/lib/icons/Home.svelte, CommentsTwo.svelte Extended icon props for color/fill customization; switched Home icon to outline style; dynamic fill for Comments.
.../src/lib/icons/Camera.svelte, Search.svelte Added new Camera and Search icon components with customizable props and SVG markup.
.../src/lib/icons/index.ts Exported new Camera and Search icons.
.../src/lib/fragments/BottomNav/BottomNav.svelte, BottomNav.stories.ts Added BottomNav component with tab navigation, animation logic, and Storybook story.
.../src/lib/fragments/index.ts Exported BottomNav from fragments module.
.../src/lib/store/store.svelte.ts Introduced isNavigatingThroughNav reactive state for navigation tracking.
.../src/routes/+layout.svelte Integrated view transition animations on navigation using isNavigatingThroughNav.
.../src/routes/(protected)/+layout.svelte Added protected layout rendering children and BottomNav.
.../src/routes/(protected)/home/+page.svelte, discover/+page.svelte, messages/+page.svelte, Added new page components for protected routes: home, discover, messages, post, profile.
.../src/routes/(protected)/post/+page.svelte, profile/+page.svelte
.../src/routes/+page.svelte Replaced static content with redirect to /home.
.../src/app.css Added CSS for sliding and fading view transitions.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant BottomNav
    participant Store
    participant Router
    participant Document

    User->>BottomNav: Clicks a navigation tab
    BottomNav->>Store: Set isNavigatingThroughNav.value = true
    BottomNav->>Document: Set data-transition attribute (left/right)
    BottomNav->>Router: goto(target route)
    Router->>Document: Triggers view transition animation
    Document->>BottomNav: Animation completes, navigation state resets
Loading

Assessment against linked issues

Objective Addressed Explanation
Implement a bottom navigation bar with expected look/behavior (#126)
Provide animated transitions for navigation (#126)

Poem

A rabbit leaps with nimble feet,
Across the tabs, transitions neat.
Slide left, slide right, the views align,
With icons polished, all divine.
At the bottom, nav so bright—
Hop along, enjoy the sight!
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ghost ghost self-assigned this May 13, 2025
@ghost ghost marked this pull request as draft May 13, 2025 07:47
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Nitpick comments (1)
platforms/metagram/src/lib/ui/BottomNav/BottomNav.svelte (1)

7-10: TypeScript interface could be more specific

The activeTab type is very broad (string | number) which could allow invalid values. Consider using a union type of specific valid tab names.

interface IBottomNavProps extends HTMLAttributes<HTMLElement> {
-    activeTab: string | number;
+    activeTab: "home" | "search" | "scan" | "comments" | "profile";
}
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 75a6aa9 and f0cc8e8.

📒 Files selected for processing (4)
  • platforms/metagram/src/lib/icons/Home.svelte (1 hunks)
  • platforms/metagram/src/lib/ui/BottomNav/BottomNav.stories.ts (1 hunks)
  • platforms/metagram/src/lib/ui/BottomNav/BottomNav.svelte (1 hunks)
  • platforms/metagram/src/lib/ui/index.ts (1 hunks)
🔇 Additional comments (4)
platforms/metagram/src/lib/ui/index.ts (1)

3-3: LGTM: Clean export of the new BottomNav component

The export properly exposes the new BottomNav component, making it available for use in other components following the project's existing export pattern.

platforms/metagram/src/lib/ui/BottomNav/BottomNav.stories.ts (1)

1-17: LGTM: Well-structured Storybook story configuration

The story follows standard Storybook patterns with proper typing and autodocs configuration. The story provides a clean way to document and test the BottomNav component in isolation.

platforms/metagram/src/lib/icons/Home.svelte (2)

4-4: LGTM: Proper extension of icon props with color and fill

The component now supports customizable colors with sensible defaults, which is essential for the dynamic styling in the BottomNav component.


7-9: LGTM: SVG icon refactored for dynamic styling

The SVG implementation has been properly refactored from a gradient-fill style to a stroke-based approach that supports dynamic color changes. The stroke properties correctly use the provided color prop.

@ghost ghost marked this pull request as ready for review May 14, 2025 03:37
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

♻️ Duplicate comments (1)
platforms/metagram/src/lib/ui/BottomNav/BottomNav.svelte (1)

20-129: Implement proper text labels for accessibility

The navigation only uses icons without visible text labels or aria-labels, which creates accessibility barriers. Users who rely on screen readers won't know what each tab represents.

Add descriptive text labels or at minimum include aria-label attributes for each tab:

🧹 Nitpick comments (2)
platforms/metagram/src/lib/ui/BottomNav/BottomNav.svelte (2)

6-18: Use a more robust approach to navigation

The current navigation implementation uses a simple goto without any fallback or error handling. This could lead to unexpected behavior if the route doesn't exist.

Enhance the navigation handler to include error handling:

 import { goto } from '$app/navigation';
+import { browser } from '$app/environment';

 interface IBottomNavProps extends HTMLAttributes<HTMLElement> {
   activeTab: string;
   profileSrc: string;
+  onTabChange?: (tab: string) => void;
 }
 let {
   activeTab = $bindable('home'),
-  profileSrc = 'https://picsum.photos/200'
+  profileSrc = 'https://picsum.photos/200',
+  onTabChange = undefined
 }: IBottomNavProps = $props();

 const handleClick = () => {
-  goto(`/${activeTab}`);
+  if (onTabChange) {
+    onTabChange(activeTab);
+  } else if (browser) {
+    goto(`/${activeTab}`).catch(err => {
+      console.error(`Navigation failed: ${err.message}`);
+    });
+  }
 };

This provides flexibility for parent components to handle tab changes and adds error handling for the navigation.


109-119: Consider consistent active state indicators

The profile tab uses a different visual indicator (border) for its active state compared to other tabs (color change). This inconsistency may confuse users about the current state.

Either add a color indicator to the profile image border for consistency or add borders to all tabs when active:

 <span
-  class={`inline-block w-full rounded-full border p-1 ${activeTab === 'profile' ? 'border-brand-burnt-orange' : 'border-transparent'}`}
+  class={`inline-block w-full rounded-full border p-1 ${
+    activeTab === 'profile' 
+      ? 'border-brand-burnt-orange bg-brand-burnt-orange bg-opacity-10' 
+      : 'border-transparent'
+  }`}
 >

This adds a subtle background color when active for better visual consistency with other tabs.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f0cc8e8 and 1bd4de5.

📒 Files selected for processing (10)
  • platforms/metagram/src/lib/icons/Camera.svelte (1 hunks)
  • platforms/metagram/src/lib/icons/CommentsTwo.svelte (1 hunks)
  • platforms/metagram/src/lib/icons/Home.svelte (1 hunks)
  • platforms/metagram/src/lib/icons/Search.svelte (1 hunks)
  • platforms/metagram/src/lib/icons/index.ts (1 hunks)
  • platforms/metagram/src/lib/ui/Avatar/Avatar.stories.ts (1 hunks)
  • platforms/metagram/src/lib/ui/Avatar/Avatar.svelte (1 hunks)
  • platforms/metagram/src/lib/ui/BottomNav/BottomNav.stories.ts (1 hunks)
  • platforms/metagram/src/lib/ui/BottomNav/BottomNav.svelte (1 hunks)
  • platforms/metagram/src/lib/ui/index.ts (1 hunks)
✅ Files skipped from review due to trivial changes (6)
  • platforms/metagram/src/lib/icons/index.ts
  • platforms/metagram/src/lib/ui/Avatar/Avatar.stories.ts
  • platforms/metagram/src/lib/ui/Avatar/Avatar.svelte
  • platforms/metagram/src/lib/icons/Camera.svelte
  • platforms/metagram/src/lib/ui/BottomNav/BottomNav.stories.ts
  • platforms/metagram/src/lib/icons/Search.svelte
🚧 Files skipped from review as they are similar to previous changes (2)
  • platforms/metagram/src/lib/ui/index.ts
  • platforms/metagram/src/lib/icons/Home.svelte
🔇 Additional comments (2)
platforms/metagram/src/lib/icons/CommentsTwo.svelte (1)

4-4: Good enhancement to component flexibility!

Adding the configurable fill prop makes this icon component more reusable, aligning with the pattern used in other icon components. This change allows the BottomNav to dynamically style the icon based on active state.

Also applies to: 11-11

platforms/metagram/src/lib/ui/BottomNav/BottomNav.svelte (1)

21-25: Good implementation of semantic HTML

Using the <nav> element with appropriate ARIA attributes is a good practice for accessibility and semantic HTML. This correctly addresses a previously raised issue.

Copy link
Member

@sosweetham sosweetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add this to the page and implement animations on navigate too same as before

this is a web app and this bottom bar would only render on mobile screens

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Nitpick comments (4)
platforms/metagram/src/routes/+layout.svelte (1)

7-7: Consider adding type annotation for activeTab.

The reactive state variable activeTab would benefit from explicit type annotation. This would better document the expected values and improve maintainability.

-	let activeTab = $state('home');
+	let activeTab: string = $state('home');
platforms/metagram/src/lib/fragments/BottomNav/BottomNav.svelte (3)

6-13: Consider using a union type for activeTab instead of string.

Using a string type for activeTab allows any string value, which could lead to unexpected behavior. Consider using a union type to restrict the possible values to the actual tabs.

+	type TabValue = 'home' | 'search' | 'camera' | 'messages' | 'profile';
+
 	interface IBottomNavProps extends HTMLAttributes<HTMLElement> {
-		activeTab: string;
+		activeTab: TabValue;
 		profileSrc: string;
 	}
 	let {
-		activeTab = $bindable('home'),
+		activeTab = $bindable('home' as TabValue),
 		profileSrc = 'https://picsum.photos/200'
 	}: IBottomNavProps = $props();

28-36: Refactor repetitive tab styling logic.

The styling pattern is repeated for each tab. Consider creating a reusable component for navigation tabs to eliminate duplication.

<!-- TabItem.svelte -->
<script lang="ts">
  import type { ComponentType } from 'svelte';
  
  export let id: string;
  export let label: string;
  export let icon: ComponentType;
  export let isActive: boolean;
  export let onClick: () => void;
  export let profileSrc: string | undefined = undefined;
</script>

<button
  id="{id}-tab"
  role="tab"
  aria-selected={isActive}
  aria-controls="{id}-panel"
  class="flex flex-col items-center focus:outline-none focus:ring-2 focus:ring-brand-burnt-orange"
  on:click={onClick}
>
  {#if profileSrc}
    <span class={`inline-block w-full rounded-full border p-1 ${isActive ? 'border-brand-burnt-orange' : 'border-transparent'}`}>
      <img
        width="24px"
        height="24px"
        class="aspect-square rounded-full"
        src={profileSrc}
        alt={label}
      />
    </span>
  {:else}
    <svelte:component 
      this={icon}
      size="24px"
      color={isActive ? 'var(--color-brand-burnt-orange)' : 'var(--color-black-400)'}
      fill={isActive ? 'var(--color-brand-burnt-orange)' : 'white'}
    />
  {/if}
  <span class="sr-only">{label}</span>
</button>

Then in the main component:

<script>
  // ... other imports
  import TabItem from './TabItem.svelte';
  
  const tabs = [
    { id: 'home', label: 'Home', icon: Home },
    { id: 'search', label: 'Search', icon: Search },
    { id: 'camera', label: 'Camera', icon: Camera },
    { id: 'messages', label: 'Messages', icon: CommentsTwo },
    { id: 'profile', label: 'Profile' }
  ];
  
  const handleTabClick = (tabId) => {
    activeTab = tabId;
    handleClick();
  };
</script>

<nav aria-label="Main navigation" class="fixed start-0 bottom-0 flex w-full items-center justify-between px-7 py-2 sm:hidden" role="tablist">
  {#each tabs as tab}
    {#if tab.id === 'profile'}
      <TabItem 
        id={tab.id}
        label={tab.label}
        isActive={activeTab === tab.id}
        onClick={() => handleTabClick(tab.id)}
        profileSrc={profileSrc}
      />
    {:else}
      <TabItem 
        id={tab.id}
        label={tab.label}
        icon={tab.icon}
        isActive={activeTab === tab.id}
        onClick={() => handleTabClick(tab.id)}
      />
    {/if}
  {/each}
</nav>

Also applies to: 48-56, 68-76, 88-96, 108-120


23-23: Consider adding more responsive styling classes.

The component only hides on small screens (sm:hidden) but doesn't specify alternative navigation for different screen sizes. Consider adding more comprehensive responsive styling.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1bd4de5 and fb3e0ba.

📒 Files selected for processing (5)
  • platforms/metagram/src/lib/fragments/BottomNav/BottomNav.stories.ts (1 hunks)
  • platforms/metagram/src/lib/fragments/BottomNav/BottomNav.svelte (1 hunks)
  • platforms/metagram/src/lib/fragments/index.ts (1 hunks)
  • platforms/metagram/src/lib/ui/index.ts (1 hunks)
  • platforms/metagram/src/routes/+layout.svelte (1 hunks)
✅ Files skipped from review due to trivial changes (3)
  • platforms/metagram/src/lib/ui/index.ts
  • platforms/metagram/src/lib/fragments/index.ts
  • platforms/metagram/src/lib/fragments/BottomNav/BottomNav.stories.ts
🔇 Additional comments (3)
platforms/metagram/src/routes/+layout.svelte (1)

2-2: LGTM: Clean import of the BottomNav component.

The import statement is well-organized and follows the project's structure conventions.

platforms/metagram/src/lib/fragments/BottomNav/BottomNav.svelte (2)

3-4: LGTM: Clean imports for icons and navigation.

The imports are well-organized and appropriate for the component's functionality.


20-25: LGTM: Proper ARIA labeling on the navigation element.

Good use of aria-label and role attributes for accessibility.

@ghost ghost requested a review from sosweetham May 14, 2025 04:56
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (4)
platforms/metagram/src/routes/(protected)/messages/+page.svelte (1)

9-9: Consider enhancing this placeholder page.

The current implementation is a minimal placeholder. As development progresses, consider adding more content, proper styling, and potentially loading states for this messages view.

platforms/metagram/src/routes/(protected)/discover/+page.svelte (1)

9-9: Consider developing the page content further.

The current page is a minimal placeholder. As development continues, consider adding more comprehensive content, appropriate styling, and possibly loading states for the discover functionality.

platforms/metagram/src/routes/(protected)/+layout.svelte (1)

1-11: Layout implementation looks good but consider a few improvements

The layout correctly implements the Bottom Navigation integration for protected routes. However, there are a few things to improve:

  1. The hardcoded profile image URL is not suitable for production code. Consider using a more robust solution like:

    • A user-specific profile image from an authentication context
    • A default image from your assets directory rather than an external service
  2. Consider adding some basic styling for the main element to handle spacing and ensure the bottom navigation doesn't overlap with content.

<script lang="ts">
	import { BottomNav } from '$lib/fragments';
	import { activeTab } from './store.svelte';
+	import { user } from '$lib/stores/auth'; // assuming you have an auth store

	let { children } = $props();
</script>

-<main>
+<main class="pb-16"> <!-- Add padding to prevent content from being hidden behind nav -->
	{@render children()}
-	<BottomNav bind:activeTab={activeTab.value} profileSrc="https://picsum.photos/200" />
+	<BottomNav bind:activeTab={activeTab.value} profileSrc={$user?.profileImage || '/images/default-avatar.png'} />
</main>
platforms/metagram/src/routes/(protected)/home/+page.svelte (1)

9-9: Consider expanding the home page content

The current implementation has only a basic heading element. If this is intended as a placeholder, that's fine, but if this is meant for production, consider expanding the content to match the design requirements for the home page.

-<h1>Home</h1>
+<section class="home-feed">
+   <h1 class="text-2xl font-bold mb-4">Home</h1>
+   <!-- Feed content would go here -->
+   <div class="feed-placeholder">
+     <p>Feed content coming soon...</p>
+   </div>
+</section>
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0720e3a and 1e970f9.

📒 Files selected for processing (11)
  • platforms/metagram/src/lib/fragments/BottomNav/BottomNav.svelte (1 hunks)
  • platforms/metagram/src/lib/fragments/index.ts (1 hunks)
  • platforms/metagram/src/routes/(protected)/+layout.svelte (1 hunks)
  • platforms/metagram/src/routes/(protected)/discover/+page.svelte (1 hunks)
  • platforms/metagram/src/routes/(protected)/home/+page.svelte (1 hunks)
  • platforms/metagram/src/routes/(protected)/messages/+page.svelte (1 hunks)
  • platforms/metagram/src/routes/(protected)/post/+page.svelte (1 hunks)
  • platforms/metagram/src/routes/(protected)/profile/+page.svelte (1 hunks)
  • platforms/metagram/src/routes/(protected)/store.svelte.ts (1 hunks)
  • platforms/metagram/src/routes/+layout.svelte (1 hunks)
  • platforms/metagram/src/routes/+page.svelte (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • platforms/metagram/src/routes/(protected)/profile/+page.svelte
  • platforms/metagram/src/routes/(protected)/post/+page.svelte
🚧 Files skipped from review as they are similar to previous changes (3)
  • platforms/metagram/src/routes/+layout.svelte
  • platforms/metagram/src/lib/fragments/index.ts
  • platforms/metagram/src/lib/fragments/BottomNav/BottomNav.svelte
🔇 Additional comments (4)
platforms/metagram/src/routes/(protected)/store.svelte.ts (1)

1-3: Clean implementation of reactive tab state management.

The activeTab store is well-implemented using Svelte's reactive state system. This approach will effectively track the current tab across different components of the application.

platforms/metagram/src/routes/(protected)/messages/+page.svelte (1)

1-7: Good implementation of tab state management.

The reactive effect correctly sets the active tab to 'messages' when this component is mounted or updated, ensuring proper synchronization with the navigation UI.

platforms/metagram/src/routes/(protected)/discover/+page.svelte (1)

1-7: Effective tab state management.

The component correctly sets the active tab to 'discover' when mounted, which will properly sync with the BottomNav component.

platforms/metagram/src/routes/(protected)/home/+page.svelte (1)

1-7: The activeTab store integration looks good

The implementation correctly sets the active tab when navigating to the home page. The use of $effect is appropriate here since it will run when the component is mounted.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (4)
platforms/metagram/src/routes/+layout.svelte (4)

7-7: Remove unused variable.

The previousRoute variable is declared but never used in the active code. It appears only in commented-out code which suggests it may be part of an incomplete implementation.

-	let previousRoute = null;

18-19: Consider dynamic transition direction based on navigation context.

The transition direction is hardcoded to 'right', which may create unintuitive animations when navigating backwards in the application. Consider determining the direction dynamically based on the navigation path or navigation history.

-	const currentDirection = 'right';
-	document.documentElement.setAttribute('data-transition', currentDirection);
+	// Determine direction based on navigation context (forward = right, backward = left)
+	const isBackNavigation = navigation.type === 'pop';
+	const currentDirection = isBackNavigation ? 'left' : 'right';
+	document.documentElement.setAttribute('data-transition', currentDirection);

20-25: Remove commented code.

There are several commented code lines that aren't providing value. Either implement this logic or remove it to keep the codebase clean and maintainable.

-	// if (!runtime.isNavigatingThroughNav) {
-	// 	const currentDirection = 'right';
-
-	// 	document.documentElement.setAttribute('data-transition', currentDirection);
-	// 	previousRoute = targetRoute;
-	// }

10-10: Add graceful fallback for browsers without View Transitions API support.

The code currently returns early when document.startViewTransition is not supported, but doesn't provide any fallback behavior. Consider implementing a simpler transition for browsers that don't support this API.

-	if (!document.startViewTransition) return;
+	if (!document.startViewTransition) {
+		// Provide simple fallback - set a class for CSS-only transitions
+		document.documentElement.classList.add('navigating');
+		navigation.complete.then(() => {
+			// Remove class after navigation completes
+			setTimeout(() => {
+				document.documentElement.classList.remove('navigating');
+			}, 300); // Match timing with your CSS transitions
+		});
+		return;
+	}
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1e970f9 and a6a6643.

📒 Files selected for processing (3)
  • platforms/metagram/src/app.css (1 hunks)
  • platforms/metagram/src/lib/fragments/BottomNav/BottomNav.svelte (1 hunks)
  • platforms/metagram/src/routes/+layout.svelte (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • platforms/metagram/src/app.css
🚧 Files skipped from review as they are similar to previous changes (1)
  • platforms/metagram/src/lib/fragments/BottomNav/BottomNav.svelte
🔇 Additional comments (1)
platforms/metagram/src/routes/+layout.svelte (1)

36-38: Good semantic HTML structure and accessibility improvement.

Wrapping the content in a <main> element improves the semantic structure of the document and benefits accessibility. This is a good practice.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
platforms/metagram/src/routes/+layout.svelte (2)

8-9: Consider adding type annotation for previousRoute.

While TypeScript can infer the type, adding an explicit type annotation would improve code readability and prevent potential type-related issues.

-let previousRoute = null;
+let previousRoute: string | null = null;

20-25: Consider dynamic transition direction based on navigation context.

The transition direction is hardcoded as 'right' for all non-nav-bar navigations. This might feel unnatural for certain navigation patterns, like returning to a previous page.

Consider determining the direction based on navigation context or navigation history:

if (!isNavigatingThroughNav.value) {
-	const currentDirection = 'right';
+	// Determine direction based on navigation history or depth
+	const currentDirection = determineNavigationDirection(currentRoute, targetRoute);

	document.documentElement.setAttribute('data-transition', currentDirection);
	previousRoute = targetRoute;
}

// Add this helper function
+ function determineNavigationDirection(from: string | undefined, to: string | undefined): string {
+   // Example logic - you could implement more sophisticated routing-based logic
+   // For instance, compare route segments or use navigation history
+   if (!from || !to) return 'right';
+   
+   // Forward navigation for deeper paths, backward for shallower paths
+   return from.split('/').length < to.split('/').length ? 'right' : 'left';
+ }
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between a6a6643 and b3654c5.

📒 Files selected for processing (3)
  • platforms/metagram/src/lib/fragments/BottomNav/BottomNav.svelte (1 hunks)
  • platforms/metagram/src/lib/store/store.svelte.ts (1 hunks)
  • platforms/metagram/src/routes/+layout.svelte (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • platforms/metagram/src/lib/fragments/BottomNav/BottomNav.svelte
🔇 Additional comments (3)
platforms/metagram/src/lib/store/store.svelte.ts (1)

1-3: Clear and concise state implementation for navigation tracking.

The state implementation using $state is clean and provides a clear indicator for tracking navigation through the bottom nav. The use of an object with a value property (instead of a simple boolean) ensures consistent reference passing across components.

platforms/metagram/src/routes/+layout.svelte (2)

2-3: Good imports for navigation handling.

The imports are appropriate for the feature being implemented, bringing in both the navigation hook and the state store needed for tracking navigation source.


36-38: Appropriate structural update with main element.

Wrapping the content in a <main> element improves semantic HTML structure and accessibility.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
platforms/metagram/src/routes/(protected)/home/+page.svelte (2)

1-10: Script section looks good with one improvement opportunity.

The script section properly imports required dependencies and sets up the active tab correctly. The $effect reactive block ensures the home tab is correctly set as active whenever component state changes.

Consider adding a brief comment explaining the purpose of the $effect block to improve code maintainability.


12-17: Consider enhancing the UI and adding error handling.

The home page is currently very minimal with just a heading and button. While this might be a placeholder for future content, it's worth considering:

  1. Adding error handling for the navigation action
  2. Using a more descriptive button label (capitalize "Discover")
  3. Providing more context or content appropriate for a home page
<h1>Home</h1>
<Button
	callback={async () => {
-		(isNavigatingThroughNav.value = false), goto('/discover');
+		try {
+			isNavigatingThroughNav.value = false;
+			await goto('/discover');
+		} catch (error) {
+			console.error('Navigation failed:', error);
+			// Handle error appropriately
+		}
-	}}>discover</Button
+	}}>Discover</Button
>
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between b3654c5 and 8827020.

📒 Files selected for processing (1)
  • platforms/metagram/src/routes/(protected)/home/+page.svelte (1 hunks)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
platforms/metagram/src/routes/(protected)/post/+page.svelte (3)

1-4: This appears to be a minimal placeholder page

The page currently only contains a title and an empty TypeScript block. While this may be intentional as part of the BottomNav implementation PR, consider:

  1. Adding a brief comment explaining this is a placeholder for future implementation
  2. Documenting how this page integrates with the new navigation system
  3. Adding basic structure that would be expected in a post page (even if non-functional)

If this is intentionally minimal at this stage, consider adding a comment to indicate this:

<script lang="ts">
+// Placeholder for post creation functionality - to be implemented in future PR
</script>

<h1>Post</h1>

1-2: Consider removing empty TypeScript block if unused

The TypeScript script block is currently empty. If no TypeScript logic is needed for this component at this stage, you could remove it for cleaner code.

-<script lang="ts">
-</script>

4-4: Improve heading semantic structure

For better accessibility and semantic HTML structure, consider adding a more descriptive heading or additional content that explains what this page is for.

-<h1>Post</h1>
+<h1>Create New Post</h1>
+<p>This page will allow users to create and share new content.</p>
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 8827020 and d3924bf.

📒 Files selected for processing (7)
  • platforms/metagram/src/lib/fragments/BottomNav/BottomNav.svelte (1 hunks)
  • platforms/metagram/src/routes/(protected)/+layout.svelte (1 hunks)
  • platforms/metagram/src/routes/(protected)/discover/+page.svelte (1 hunks)
  • platforms/metagram/src/routes/(protected)/home/+page.svelte (1 hunks)
  • platforms/metagram/src/routes/(protected)/messages/+page.svelte (1 hunks)
  • platforms/metagram/src/routes/(protected)/post/+page.svelte (1 hunks)
  • platforms/metagram/src/routes/(protected)/profile/+page.svelte (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • platforms/metagram/src/routes/(protected)/discover/+page.svelte
🚧 Files skipped from review as they are similar to previous changes (5)
  • platforms/metagram/src/routes/(protected)/messages/+page.svelte
  • platforms/metagram/src/routes/(protected)/profile/+page.svelte
  • platforms/metagram/src/routes/(protected)/+layout.svelte
  • platforms/metagram/src/routes/(protected)/home/+page.svelte
  • platforms/metagram/src/lib/fragments/BottomNav/BottomNav.svelte
🔇 Additional comments (1)
platforms/metagram/src/routes/(protected)/post/+page.svelte (1)

1-5:

✅ Verification successful

Ensure consistent styling with other protected pages

Check that this page follows the same styling patterns as other protected route pages (home, discover, messages, profile) to ensure a consistent user experience across the application.

Check if other protected pages have similar structure or if they include more elements such as wrapper divs, specific classes, or styling.


🏁 Script executed:

#!/bin/bash
# Find similar protected route pages and check their structure
fd --type file '+page.svelte' 'platforms/metagram/src/routes/\(protected\)/' --exec cat {} \; | grep -v "src/routes/(protected)/post/+page.svelte"

Length of output: 281


To accurately compare the structure of your protected pages, let’s list every +page.svelte under the (protected) folder and output the first 20 lines of each:


🏁 Script executed:

#!/bin/bash
# List all protected-route +page.svelte files and show their first 20 lines
find platforms/metagram/src/routes -type f -name '+page.svelte' | grep '/(protected)/' | while read -r f; do
  echo "=== File: $f ==="
  sed -n '1,20p' "$f"
  echo
done

Length of output: 1897


Styling Consistency Verified Across Protected Pages
The post page uses the same minimal structure (empty <script lang="ts"> + a single <h1>…</h1>) as discover, messages, and profile. The only outlier is home, which intentionally includes a <Button>.

If you plan to introduce shared wrappers or utility classes, apply them uniformly to all protected pages. Otherwise, the current styling is consistent.

Copy link
Contributor

@JulienAuvo JulienAuvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JulienAuvo JulienAuvo merged commit c78b9f9 into main May 19, 2025
3 of 4 checks passed
@JulienAuvo JulienAuvo deleted the feat/BottomNav branch May 19, 2025 07:11
@coderabbitai coderabbitai bot mentioned this pull request Jun 7, 2025
6 tasks
coodos pushed a commit that referenced this pull request Jul 7, 2025
* feat: BottomNav

* fix: icons

* feat: profile icons created

* feat: handler added

* feat: handler added

* fix: correct tags

* fix: as per given suggestion, bottomnav moved to fragments and also implemented on page

* fix: handler

* chore: routes added

* feat: app transitions added

* fix: direction of transition

* fix: transition css

* fix: directionable transition

* fix: used button instead of label, and used page from state
coodos added a commit that referenced this pull request Jul 7, 2025
* initial commit

* chore: add w3id readme (#3)

* chore: add w3id readme

* chore: bold text

* chore: better formatting

* docs: add w3id details

* chore: format

* chore: add links

* fix: id spec considerations addressal (#8)

* fix: id spec considerations addressal

* fix: identity -> indentifier

* chore: expand on trust list based recovery

* chore: expand on AKA

---------

Co-authored-by: Merul Dhiman <[email protected]>

* Docs/eid wallet (#10)

* chore: add eid-wallet folder

* chore: add eid wallet docs

* feat: add (#9)

* feat(w3id): basic setup (#11)

* feat(w3id): basic setup

* fix(root): add infrastructure workspaces

* update: lock file

* feat(eidw): setup tauri (#40)

* Feat/setup daisyui (#46)

* feat: setup-daisyui

* fix: index file

* feat: colors added

* feat: Archivo font added

* fix: postcss added

* fix: +layout.svelte file added

* fix: packages

* fix: fully migrating to tailwind v4

* feat: add Archivo font

* feat: add danger colors

* feat: twmerge and clsx added

* feat: shadcn function added

---------

Co-authored-by: Bekiboo <[email protected]>
Co-authored-by: Julien <[email protected]>

* feat: add storybook (#45)

* feat: add storybook

* update: lockfile

* feat: created connection button (#48)

* created connection button

* added restprops to parent class

* added onClick btn and storybook

* fix: make font work in storybook (#54)

* Feat/header (#55)

* feat: add icons lib

* fix: make font work in storybook

* feat: Header

* feat: runtime global added, icon library created, icons added, type file added

* feat: header props added

* fix: remove icons and type file as we are using lib for icons

* fix: heading style

* fix: color and icons, git merge branch 51, 54

* fix: color

* fix: header-styling

* fix: classes

* chore: handlers added

* chore: handlers added

* fix: added heading

---------

Co-authored-by: Soham Jaiswal <[email protected]>

* Alternative w3id diagram (#52)

* Feat/cupertino pane (#49)

* feat: Drawer

* feat: Drawer and added a function for clickoutside in utils

* fix: classes

* fix: drawer button position

* fix: style and clickoutside

* fix: pane height

* fix: border-radius

* fix: drawer as bulletin

* fix: styling

* fix: component with inbuilt features

* fix: remove redundant code

* fix: remove redundant code

* fix: cancel button

* fix: css in storybook

* fix: position

* fix: height of pane

* fix: remove redundant code

* feat: add button action component (#47)

* feat: add button action component

* fix: add correct weights to Archivo fontt

* feat: add base button

* fix: set prop classes last

* feat: improve loading state

* chore: cleanup

* feat: add button action component

* fix: add correct weights to Archivo fontt

* feat: add base button

* fix: set prop classes last

* feat: improve loading state

* chore: cleanup

* chore: add documentation

* fix: configure Storybook

* chore: storybook gunk removal

* feat: enhance ButtonAction component with type prop and better error handling

---------

Co-authored-by: JulienAuvo <[email protected]>

* Feat/splash screen (#63)

* feat: SplashScreen

* fix: remove redundant code

* fix: as per given suggestion

* fix: font-size

* fix: logo

* feat: input-pin (#56)

* feat: input-pin

* fix: styling as per our design

* fix: added small variant

* fix: hide pin on select

* fix: gap between pins

* fix: color of focus state

* fix: removed legacy code and also fix some css to tailwind css

* fix: css

* fix: optional props

* feat: added color variants

* Feat/improve button component (#60)

* feat: add white variant

* feat: add small variant

* chore: update doc and story for button

* chore: rename cb into callback

* update: improve small size

* update: modify loading style

* fix: return getAbsolutePath function to storybook (#58)

Co-authored-by: Bekiboo <[email protected]>

* feat: add selector component (#59)

* feat: add selector component

* feat: improve selector + add flag-icon lib

* feat: improve selector + doc

* feat: add utility function to get language with country name

* feat: test page for language selectors

* chore: add Selector Story

* chore: clean test page

* fix: types

* fix: normalize custom tailwind colors (#71)

* feat: workflows (#64)

* feat: workflows

* fix: node version

* fix: use pnpm 10

* fix: check message

* Fix/codebase linting (#73)

* fix: Check Lint / lint

* fix: Check Lint / lint

* fix: Check Lint / lint

* fix: Check Lint / lint

* fix: Check Code / lint

* fix: Check Format / lint

* fix: Check Code / lint

* fix: Check Format / lint

* fix: Check Code / lint

* fix: Check Format / lint

* fix: Check Code / lint

* fix: Check Code / lint

* fix: Check Format / lint

* fix: unknown property warning

* fix: unknown property warning

* chore: improve args type

* settings nav button :) (#75)

* setting bav button all done :)

* lint fixski

* added component to index.ts

* Feat/#32 identity card fragment (#74)

* identity card

* identity card

* lint fixski

* lint fixski

* lint fixski

* fixed the font weight

* added component to index.ts

* changed span to buttton

* feat: add icon button component (#68)

* feat: add icon button component

* feat: finish up buttonIcon + stories

* fix: update with new color naming

* feat: polish button icon (and button action too)

* chore: format lint

* chore: sort imports

* chore: format, not sure why

* Feat/onboarding flow (#67)

* feat: onboarding-page

* fix: line height and added handlers

* fix: button variant

* fix: text-decoration

* fix: subtext

* fix: underline

* fix: padding and button spacing

* fix: according to design update

* feat: Drawer

* feat: verify-pae

* fix: verify-page styling

* feat: drawer for both confirm pin and add bio metrics added

* feat: modal added in fragments

* fix: icons and flow

* feat: Identifier Card

* fix: copy to clipboard

* feat: e-passport page

* fix: error state

* fix: colors

* fix: lint error

* fix: lint

* feat: Typography

* fix: typograpy

* fix: as per given suggestion

* fix: font-sizing

* fix: identity card implementation

* fix: spacing

* fix: padding

* fix: padding and spacing

* fix: splashscreen

* fix: error state

* fix: styling to avoid

* fix:typo

* Fix/remove daisyui (#82)

* refactoring: remove DaisyUI + refactor some tailwind classes and logic

* refactoring: remove DaisyUI + refactor some tailwind classes and logic

* feat: add Button.Nav (#77)

* feat: add Button.Nav

* chore: format

* chore: sort imports

* update: remove unused snippet and add missing props

* feat: stick to fragment definition

* update: documentation

* fix: stories

* chore: sort imports

* Feat/splashscreen animation (#81)

* feat: add animation to splashScreen

* feat: implement data loading logic with splash screen delay

* chore: sort import

* update: use ButtonIcon is IdentityCard (#78)

* update: use ButtonIcon is IdentityCard

* feat: refactor ButtonIcon to be used anywhere in the app

* chore: format indent

* chore: remove useless change

* feat: setup safe area (#80)

* feat: setup safe area

* chore: simplify implementation

* chore: format

* Feat/uuidv5 generation (#61)

* feat: setup uuidv5

* chore: add test for deterministic UUID

* feat: add Hero fragment (#88)

* feat: add Hero fragment

* chore: sort imports + add doc

* feat: add storage specification abstract class (#92)

* feat: add storage specification abstract class

* chore: format and ignore lint

* chore: change format checker on w3id

* feat: settings-flow (#86)

* feat: settings-flow

* feat: settings and language page

* feat
: history page

* feat: change pin page

* fix: height of selector

* fix: pin change page

* fix: size of input pin

* fix: spacing of pins

* feat: AppNav fragment

* fix: height of page

* fix: padding

* fix: remove redundant code

* feat: privacy page

* chore: add doc

* fix: error state

* feat: remove redundant code

* chore: used app nav component

---------

Co-authored-by: JulienAuvo <[email protected]>

* feat: AppNav fragment (#90)

* feat: AppNav fragment

* chore: add doc

* feat: Main page flow (#93)

* feat: create root page + layout

* feat: complete main page flow beta

* chore: fix ts block

* chore: sort imports

* feat: integrate-flows (#94)

* feat: intigrate-flows

* fix: spacing in e-passport page

* fix: page connectivity

* feat: app page transitions

* fix: z index

* fix: pages

* fix: view transition effect on splashscreen

* fix: drawer pill and cancel button removed

* fix: share button removed when onboarding

* fix: remove share and view button when on onboarding flow

* fix: remove view button

* fix: ci checks

* fix: transitions

* fix: transititon according to direction

* fix: lint error

* fix: loop holes

* Feat/w3id log generation (#98)

* chore: create basic log generation mechanism

* chore: add hashing utility function

* chore: rotation event

* feat: genesis entry

* feat: generalize hash function

* feat: append entry

* chore: basic tests

* chore: add tests for rotation

* feat: add malform throws

* chore: add the right errors

* chore: fix CI stuff

* chore: add missing file

* chore: fix event type enum

* chore: format

* feat: add proper error

* chore: format

* chore: remove eventtypes enum

* chore: add new error for bad options

* chore: add options tests

* feat: add codec tests

* fix: err handling && jsdoc

* fix: run format

* fix: remove unused import

* fix: improve default error messages

* fix: move redundant logic to function

* fix: run format

* fix: type shadow

* fix: useless conversion/cast

* fix: run format

---------

Co-authored-by: Soham Jaiswal <[email protected]>

* Feat/core id creation logic (#99)

* feat: create w3id builder

* fix: w3id builder

* feat: add global config var for w3id

* chore: add docs

* chore: change rand to crng

* chore: add ts type again

* chore: fix lint and format

* chore: add w3id tests github workflow

* Feat/evault core (#100)

* feat: migrate neo4j

* chore: envelope logic works

* chore: envelope logic works

* feat: parsed envelopes search

* feat: generics

* feat: protocol

* feat: jwt sigs in w3id

* chore: stuff works

* chore: tests for evault core

* chore: format

* chore: fix test

* Feat/docker compose and docs (#101)

* chore: stash dockerfile progress

* fix: getEnvelopesByOntology thing

* chore: fix tests

* Update infrastructure/evault-core/src/protocol/vault-access-guard.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* chore: remove unused import

* chore: remove package

* chore: fix pnpm lock

* chore: fix workflow

* chore: fix port in dockerfile

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Feat/registry and evault provisioning (#106)

* feat: evault provisioning

* chore: fianlly fixed provisioner

* feat: add logic for metadata in consul

* feat: registry

* chore: format

* Feat/watchers logs (#114)

* feat: alloc according to entropy and namespace

* chore: move exports

* chore: docs

* feat: `whois` endpoint

* feat: watcher endpoints

* chore: fix format and lint

* chore: fix tests

* feat: web3 adapter (#115)

* feat: tauri plugins setup (#97)

* feat: tauri plugins setup

* fix: add editorconfig

* fix: add missing biome json

* fix: run formatter

* feat: biometry homework

* feat: add pin set logic

* feat: add biometric enabling logic

* fix: sec controller qol

* feat: stub user controller

* fix: run format && lint

* fix: sort imports

* fix: import statement sort

* feat: user controller

* feat: pin flow

* feat: biometrics unavailable

* fix: pin input not working

* feat: make checks pass

* fix: scan works

* fix: actions

* feat: format on save

* fix: coderabbit suggestions

* chore: run format lint check

* fix: scan on decline too

* feat: documentation links (#117)

* feat: bad namespace test (#116)

* fix: layouts (#119)

* fix: layouts

* fix: Onboarding page scroll fixed

* fix: page layout and prevent from scroll in all devices

* fix: pages layout

* chore: try to fix emulator

* fix: units

* fix: safezones for ios

* fix: styling

---------

Co-authored-by: Soham Jaiswal <[email protected]>

* feat: setup-metagram (#121)

* feat: setup-metagram

* chore: tailwind css worked

* feat: fonts added

* feat: typography

* fix: removed stories and fixed setup for icons lib

* feat: icons and story file

* fix: type of args in story

* fix: lint errors

* feat: colors added

* feat: Button

* fix: format and lint

* fix: colors

* fix: spinner

* fix: code rebbit suggestions

* fix: code rebbit suggestions

* fix: paraglide removed

* fix: lock file

* feat: added user avatar. (#130)

* feat: Button (#129)

* feat: Button

* fix: colors of variants

* feat: Input (#131)

* feat: Input

* feat: styling added

* fix: styling

* fix: styling

* fix: added a new story

* fix: focus states

* fix: input states

* Feat/settings navigation button (#140)

* feat: settings-navigation-button

* fix: handler added

* chore: another variant added

* fix: as per given suggestion

* feat: BottomNav (#132)

* feat: BottomNav

* fix: icons

* feat: profile icons created

* feat: handler added

* feat: handler added

* fix: correct tags

* fix: as per given suggestion, bottomnav moved to fragments and also implemented on page

* fix: handler

* chore: routes added

* feat: app transitions added

* fix: direction of transition

* fix: transition css

* fix: directionable transition

* fix: used button instead of label, and used page from state

* feat: added post fragment. (#137)

* feat: FileInput (#150)

* feat: FileInput

* fix: added icon

* feat: cancel upload

* fix: remove redundant code

* fix: usage docs added and as per requirements
'

* fix: moved to framents

* feat: Toggle Switch (#143)

* feat: Toggle Switch

* feat: Toggle Switch

* fix: as per our design

* fix: as per our design

* feat: Label (#146)

* feat: Select (#148)

* feat: Select

* fix: as per our design

* fix: code format and as per svelte 5

* fix: font-size

* fix: font-size

* fix: icon

* feat: message-input (#144)

* feat: message-input

* fix: classes merge and a files as a prop

* feat: variant added

* feat: icon replaced

* fix: as per code rabbit suggestions

* fix: icon

* fix: input file button

* fix: as per suggestion

* fix: classes

* fix: no need of error and disabled classes

* fix: input

* feat: invalid inputs

* feat: add number input storybook

---------

Co-authored-by: Soham Jaiswal <[email protected]>

* feat:Drawer (#152)

* feat:Drawer

* feat: Drawer with clickoutside

* fix: settings

* Feat/metagram header (#133)

* feat: added metagram header primary linear gradient.

* feat: added flash icon.

* feat: added secondary state of header.

* feat: added secondary state of header with menu.

* chore: cleaned some code.

* docs: updated component docs.

---------

Co-authored-by: SoSweetHam <[email protected]>

* Feat/metagram message (#135)

* feat: added metagram message component.

* feat: added both states of message component.

* docs: added usage docs.

* chore: exposed component from ui.

* fix: component -> fragement

---------

Co-authored-by: SoSweetHam <[email protected]>

* feat: modal (#154)

* fix: styling of modal

* fix: modal props

* fix: conflicting styles

* fix: styles of drawer

* fix: hide scrollbar in drawer

* fix: padding

* fix: used native method for dismissing of drawer

* feat: Context-Menu (#156)

* feat: Context-Menu

* fix: name of component

* fix: as per suggestion

* fix: action menu position

* fix: class

* feat: responsive-setup (#157)

* feat: responsive-setup

* fix: background color

* fix: added font fmaily

* feat: responsive setup for mobile and desktop (#159)

* feat: responsive setup for mobile and desktop

* fix: width of sidebar and rightaside

* fix: responsive layout

* feat: SideBar

* fix: added some finishing touches to sidebar and button

* fix: prevent pages transition on desktop

* fix: icon center

* feat: settings page and icon added

* feat/layout-enhancement (#168)

* feat/infinite-scroll (#170)

* feat/infinite-scroll

* fix: aspect ratio of post

* fix: bottom nav background

* settings page (#169)

* settings page layout done

* settings page layout done

* formt fix

* format fix

* format fix

* routing for settings page fixed

* settings page buttons

* merge conflict

* settings page tertiary pages

* settings pages all done

* settings pages unnecessary page deleted

* requested changes done

* requested changes done

* Feat/comments pane (#171)

* feat/comments-pane

* fix: overflow and drawer swipe

* feat: Comment fragment

* fix: comments added

* fix: comment fragment

* feat: Comments reply

* fix: message input position

* fix: post type shifted to types file

* fix: one level deep only

* fix: drawer should only be render on mobile

* fix: comments on layout page

* fix: format

* feat: messages (#174)

* feat: messages

* feat: ChatMessae

* feat: messages by id

* fix: messages page

* fix: icon name

* fix: hide bottom nav for chat

* fix: header

* fix: message bubble

* fix: message bubble

* fix: message bubble

* fix: as per suggestion

* fix: messaging

* chore: change from nomad to k8s (#179)

* chore: change from nomad to k8s

* Update infrastructure/eid-wallet/src/routes/+layout.svelte

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* feat: uri extraction

* feat: regitry stuff

* feat: registry using local db

* 📝 Add docstrings to `feat/switch-to-k8s` (#181)

Docstrings generation was requested by @coodos.

* #179 (comment)

The following files were modified:

* `infrastructure/evault-provisioner/src/templates/evault.nomad.ts`

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* chore: format

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* fix: make scan qr page work again (#185)

* feat: Discover Page (#180)

* refactor/Post (#186)

* refactor/Post

* fix: format and lint

* fix: added dots for gallery

* fix: added dots for gallery

* fix: added dots for gallery

* fix: plural name

* feat: splash-screen (#187)

* Feat/evault provisioning via phone (#188)

* feat: eid wallet basic ui for verification

* chore: evault provisioning

* feat: working wallet with provisioning

* feat: restrict people on dupes

* 📝 Add docstrings to `feat/evault-provisioning-via-phone` (#189)

Docstrings generation was requested by @coodos.

* #188 (comment)

The following files were modified:

* `infrastructure/eid-wallet/src/lib/utils/capitalize.ts`
* `infrastructure/evault-provisioner/src/utils/hmac.ts`

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* feat: added uploaded post view component. (#182)

* feat: added uploaded post view component.

* fix: fixed the outline and color.

* fix: moved function to external definition.

* fix: fixed the restProps.

* profile page (#178)

* basic layout for profile page

* fixed alt text

* merge conflict

* profile page for other users implemented

* fix: profile pages and logics

* fixed all the pages of profile

* fixed all the pages of profile

* fix: format

---------

Co-authored-by: gourav <[email protected]>

* Feat/radio input (#176)

* feat: added a radio button custom

* docs: added name option in docs.

* chore: cleaned the unnecessary classes and variables for input type radio.

* fix: moved input radio to its own component.

* fix: keydown events added.

* feat: added settings tile component. (#184)

* feat: added settings tile component.

* chore: fixed the naming convention

* chore: renamed callback to onclick

* fix: fixed the use of restProps

* fix: fixed the unnecessary onclick expose.

* fix: fixed the join function params.

* Feat/textarea (#194)

* chore: removed redundant radio

* feat: added textarea.

* fix: tabindex

* fix: removed type inconsitency.

* Feat/mobile upload flow (#193)

* fix: header logic in secondary

* fix: fixed the text in header in post

* feat: trying some hack to get file image input.

* feat: added image input on clicking the post bottom nav

* chore: got rid of non-required code.

* feat: added the logic to get the images from user on clicking post tab.

* feat: added store.

* feat: added correct conversion of files.

* feat: added the correct display of image when uploading.

* feat: added settings tile to the post page and fixed the settingsTile component type of currentStatus

* feat: added hte correct header for the audience page.

* fix: fixed the page transition not happening to audience page.

* feat: added audience setting

* feat: added store to audience.

* chore: removed console log

* feat: added post button.

* feat: correct button placement

* fix: horizontal scroll

* fix: positioning of the post button.

* fix: protecting post route when no image is selected.

* fix: improved type saftey

* feat: added memory helper function

* feat: added memory cleanup.

* Feat/social media platforms (#195)

* chore: this part works now wooohooo

* chore: stash progress

* chore: stash progress

* chore: init message data models

* feat: different socials

* chore: blabsy ready for redesign

* Feat/social media platforms (#196)

* chore: this part works now wooohooo

* chore: stash progress

* chore: stash progress

* chore: init message data models

* feat: different socials

* chore: blabsy ready for redesign

* chore: add other socials

* Feat/blabsy add clone (#198)

* chore: clone twitter

* feat: custom auth with firebase using w3ds

* chore: add chat

* feat: chat works with sync

* feat: twittex

* feat: global schemas

* feat: blabsy adapter

* refactor: shift some text messages to work on blabsy (#199)

* chore: stash progress

* chore: stash adapters

* chore: stash working extractor

* feat: adapter working properly for translating to global with globalIDs

* feat: adapter toGlobal pristine

* chore: stash

* feat: adapter working

* chore: stash until global translation from pictique

* feat: bi-directional sync prestino

* feat: bidir adapters

* chore: login redir

* chore: swap out for sqlite3

* chore: swap out for sqlite3

* chore: server conf

* feat: messages one way

* feat: ready to deploy

* feat: ready to deploy

* chore: auth thing pictique

* chore: set adapter to node

* chore: fix auth token thingy

* chore: auth thing

* chore: fix auth token thingy

* chore: port for blabsy

* feat: provision stuff

* feat: provision

* feat: provision

* feat: provision

* chore: fix sync

* feat: temporary id thing

* chore: android

* chore: fix mapper sync

* chore: fallback

* feat: add error handling on stores

* feat: fix issue with posts

* chore: fix retry loop

* Fix/author details (#229)

* fix: author-details

* fix: owner-details

* fix: author avatar

* fix: auth user avatar

* fix: error handling

* fix: author image in bottom nav

---------

Co-authored-by: Merul Dhiman <[email protected]>

* Fix/change name (#228)

* fix: corrected the name to blabsy

* fix: extra shit comming.

* fix: fixed the alignment of the display in more to look more like current twitter.

* fix: avatars (#226)

* fix: avatars

* fix: avatar in follow request page

* fix: images uploaded shown in user profile

* fix: button size

* fix: avatar

---------

Co-authored-by: Merul Dhiman <[email protected]>

* chore: temp fix sync

* chore: stash progress

* Fix/post context menu (#231)

* fix: post-context-menu

* fix: user id with post

* fix: removed redundant code

* fix: images

* fix: profile data

* fix: profile data

* fix: image cover

* fix: logout

* Fix/wallet text (#234)

* changed text as per the request and fixed styling on pages with useless scroll

* added settings button in main page which went missing somehow

* fix: consistent padding

* chore: change tags

* feat: change icon

* feat: webhook dynamic registry

* feat: make camera permission work properlyh

* chore: removed all locking mechanism thing from platforms

* feat: synchronization works perfectly

* feat: fixed everything up

* feat: changes

* chore: stats fix

* chore: fix pictique visual issues

* chore: fix cosmetic name issue

* feat: fix sync issue

* chore: fix logical issue here

* chore: add qrcode ename

* feat: add packages (#235)

* feat: add packages

* feat: add sample funcs + docs

* fixed the filled color on like icon for liked post (#239)

* feat: fake passport name

* feat: double confirmation

* chore: fix pictique login issue

* fix: make no user case redir to login

* fix: issues with wallet

---------

Co-authored-by: Soham Jaiswal <[email protected]>
Co-authored-by: SoSweetHam <[email protected]>
Co-authored-by: Gourav Saini <[email protected]>
Co-authored-by: Bekiboo <[email protected]>
Co-authored-by: Julien <[email protected]>
Co-authored-by: Ananya Rana <[email protected]>
Co-authored-by: Sergey <[email protected]>
Co-authored-by: Julien Connault <[email protected]>
Co-authored-by: Ananya Rana <[email protected]>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Sahil Garg <[email protected]>
Co-authored-by: Sahil Garg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] SPs [Metagram](Fragments): Bottom Navigation

3 participants