Skip to content

Conversation

coodos
Copy link
Contributor

@coodos coodos commented Aug 22, 2025

Description of change

Issue Number

Type of change

  • Breaking (any change that would cause existing functionality to not work as expected)
  • New (a change which implements a new feature)
  • Update (a change which updates existing functionality)
  • Fix (a change which fixes an issue)
  • Docs (changes to the documentation)
  • Chore (refactoring, build scripts or anything else that isn't user-facing)

How the change has been tested

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • New Features

    • Start Monitoring now validates selections and shows an alert if none are chosen.
    • Selections persist immediately, preserving choices across navigation.
    • Monitoring page displays a “No Items Selected” view with a back button instead of auto-redirect.
    • Added clearer loading state for the flow chart.
  • Style

    • Refined monitoring layout and clarified the “Data Flow” panel header.
    • Updated settings screen version label to v0.2.0.2.

Copy link
Contributor

coderabbitai bot commented Aug 22, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Updates include a byte-wise equality check in crypto, sessionStorage-backed selection persistence and pre-navigation validation in the control panel, a Monitoring page that renders a “No Items Selected” state instead of redirecting, a minor label bump in eID Wallet settings, and Vite config tweaks for polyfills, aliases, and build options.

Changes

Cohort / File(s) Summary of Changes
Crypto: Encoding equality implementation
infrastructure/blindvote/src/crypto/pedersen.ts
Replaced Buffer.equals with manual byte-by-byte comparison including length check; no API changes.
Control Panel: Selection persistence & navigation guard
infrastructure/control-panel/src/routes/+layout.svelte, infrastructure/control-panel/src/routes/+page.svelte
Added sessionStorage persistence on selection change; Start Monitoring now validates presence of selected eVaults/platforms and alerts if none before navigating.
Monitoring UI: No-items state and load gating
infrastructure/control-panel/src/routes/monitoring/+page.svelte
Removed auto-redirect; added conditional UI for no selection vs. live monitoring; simplified SvelteFlow load gating; adjusted header/actions and layout; preserved flow markers.
eID Wallet: Settings label bump
infrastructure/eid-wallet/src/routes/(app)/settings/+page.svelte
Updated hidden button label text from “Version v0.2.0.1” to “Version v0.2.0.2”.
Build tooling: Vite config adjustments
infrastructure/eid-wallet/vite.config.js
Reduced Node polyfills to ['buffer','crypto']; defined global->globalThis for optimizeDeps; added alias 'blindvote' to source; added build.rollupOptions.external=[] and commonjs include for blindvote/node_modules.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant U as User
  participant CP as Control Panel (+page.svelte)
  participant SS as sessionStorage
  participant L as +layout.svelte
  participant M as Monitoring Page

  rect rgb(242,248,255)
  note over U,CP: Selection phase
  U->>CP: Select eVault(s)/Platform(s)
  CP->>SS: setItem("selectedEVaults", [...])
  CP->>SS: setItem("selectedPlatforms", [...])
  end

  rect rgb(245,255,245)
  note over U,L: Start Monitoring
  U->>L: Click Start Monitoring
  L->>SS: getItem("selectedEVaults"/"selectedPlatforms")
  alt Any empty/missing
    L-->>U: alert("Please select ...")
  else Valid selections
    L->>M: goto("/monitoring")
  end
  end

  rect rgb(255,250,240)
  note over M,SS: Monitoring load
  M->>SS: getItem(...)
  alt No items
    M-->>U: Render "No Items Selected" UI
  else Items present
    M-->>U: Render Live Monitoring (SvelteFlow)
  end
  end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~30 minutes

Possibly related PRs

  • chore: add few last fixes #306 — Also modifies monitoring/+page.svelte with overlapping UI and SSE/flow-panel control logic.
  • fix: button #307 — Adjusts control-panel monitoring flow and start-navigation logic overlapping with selection handling and no-items behavior.

Suggested reviewers

  • sosweetham

Poem

I nibbled wires, toggled bits so bright,
Saved your picks in sessions, snug and tight.
If nothing’s chosen, I’ll gently say,
“Hop back, dear friend—another day.”
Byte by byte, I thump in glee,
Charts now bloom for all to see. 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 6168f74 and efed108.

⛔ Files ignored due to path filters (1)
  • infrastructure/eid-wallet/src-tauri/gen/android/app/arm64/release/eid-w3ds-v0.2.0.1.apk is excluded by !**/gen/**
📒 Files selected for processing (6)
  • infrastructure/blindvote/src/crypto/pedersen.ts (1 hunks)
  • infrastructure/control-panel/src/routes/+layout.svelte (1 hunks)
  • infrastructure/control-panel/src/routes/+page.svelte (2 hunks)
  • infrastructure/control-panel/src/routes/monitoring/+page.svelte (3 hunks)
  • infrastructure/eid-wallet/src/routes/(app)/settings/+page.svelte (1 hunks)
  • infrastructure/eid-wallet/vite.config.js (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/control-panel-button-issue

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coodos coodos merged commit 018d62d into main Aug 22, 2025
0 of 3 checks passed
@coodos coodos deleted the fix/control-panel-button-issue branch August 22, 2025 18:38
This was referenced Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant