feat: charter signature verification error display

[coodos]

Description of change

Issue Number

Type of change

• Breaking (any change that would cause existing functionality to not work as expected)
• New (a change which implements a new feature)
• Update (a change which updates existing functionality)
• Fix (a change which fixes an issue)
• Docs (changes to the documentation)
• Chore (refactoring, build scripts or anything else that isn't user-facing)

How the change has been tested

Change checklist

• I have ensured that the CI Checks pass locally
• I have removed any unnecessary logic
• My code is well documented
• I have signed my commits
• My code follows the pattern of the application
• I have self reviewed my code

Summary by CodeRabbit

• New Features
  • Added explicit handling for eName/eID verification failures during charter signing, showing a clear error screen with guidance.
  • Displays a destructive toast notification when verification fails, prompting users to check their eID details.
  • Improves session termination behavior on verification failure, preventing the flow from continuing and allowing users to close and retry.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Adds a new "security_violation" terminal status to the charter signing flow: the API’s SSE stream now emits this status and terminates, and the frontend listens for it, shows a specific error state, toast, and offers a Close action.

Changes

Cohort / File(s)	Summary
Backend SSE status handling platforms/group-charter-manager-api/src/controllers/CharterSigningController.ts	Added else-if branch for session.status === "security_violation" to emit SSE event type "security_violation", clear interval, and end response.
Frontend signing UI updates platforms/group-charter-manager/src/components/charter-signing-interface.tsx	Extended internal status union with "security_violation"; on SSE event type "security_violation", set status, show destructive toast; added render branch for an error card with Close action invoking onCancel.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User as User
  participant UI as Frontend: CharterSigningInterface
  participant API as API: CharterSigningController
  participant Sess as Signing Session

  User->>UI: Open signing flow
  UI->>API: Establish SSE connection
  API->>Sess: Poll session status (interval)
  alt status: pending/connecting
    API-->>UI: SSE {type: "pending"/"connecting"}
    UI->>UI: Update progress state
  else status: completed
    API-->>UI: SSE {type: "completed"}
    API-->>UI: End SSE
    UI->>UI: Show signed state
  else status: expired
    API-->>UI: SSE {type: "expired"}
    API-->>UI: End SSE
    UI->>UI: Show expired state
  else status: security_violation
    rect rgba(255, 229, 229, 0.6)
    API-->>UI: SSE {type: "security_violation"}  Note: New terminal status
    API-->>UI: End SSE
    end
    UI->>UI: Set status=security_violation, show toast + error card
    UI->>User: Close button triggers onCancel
  end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

Thump-thump, I tap my paw with pride,
A guard now checks along our ride—
If ears twitch warnings, we abort the spree,
“Security violation,” squeaks safety’s decree.
We toast, we close, we hop anew,
The charter’s safer, code is too. 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between fc5bca6 and 34a7d1e.

📒 Files selected for processing (2)

• platforms/group-charter-manager-api/src/controllers/CharterSigningController.ts (1 hunks)
• platforms/group-charter-manager/src/components/charter-signing-interface.tsx (3 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/sse-stream-error-on-wrong-eID

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.