Skip to content

feat: charter signature verification error display #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2025
Merged

feat: charter signature verification error display #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions platforms/group-charter-manager-api/src/controllers/CharterSigningController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,10 @@ export class CharterSigningController {
res.write(`data: ${JSON.stringify({ type: "expired" })}\n\n`);
clearInterval(interval);
res.end();
} else if (session.status === "security_violation") {
res.write(`data: ${JSON.stringify({ type: "security_violation" })}\n\n`);
clearInterval(interval);
res.end();
}
} else {
res.write(`data: ${JSON.stringify({ type: "error", message: "Session not found" })}\n\n`);
Expand Down
34 changes: 33 additions & 1 deletion platforms/group-charter-manager/src/components/charter-signing-interface.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ interface CharterSigningInterfaceProps {
export function CharterSigningInterface({ groupId, charterData, onSigningComplete, onCancel, onSigningStatusUpdate }: CharterSigningInterfaceProps) {
const [sessionId, setSessionId] = useState<string | null>(null);
const [qrData, setQrData] = useState<string | null>(null);
const [status, setStatus] = useState<"pending" | "connecting" | "signed" | "expired" | "error">("pending");
const [status, setStatus] = useState<"pending" | "connecting" | "signed" | "expired" | "error" | "security_violation">("pending");
const [timeRemaining, setTimeRemaining] = useState<number>(900); // 15 minutes in seconds
const [eventSource, setEventSource] = useState<EventSource | null>(null);
const { toast } = useToast();
Expand Down Expand Up @@ -108,6 +108,13 @@ export function CharterSigningInterface({ groupId, charterData, onSigningComplet
description: "The signing session has expired. Please try again.",
variant: "destructive",
});
} else if (data.type === "security_violation") {
setStatus("security_violation");
toast({
title: "eName Verification Failed",
description: "eName verification failed. Please check your eID.",
variant: "destructive",
});
} else {
console.log("SSE message:", data);
}
Expand Down Expand Up @@ -254,6 +261,31 @@ export function CharterSigningInterface({ groupId, charterData, onSigningComplet
);
}

if (status === "security_violation") {
return (
<Card className="w-full max-w-md mx-auto">
<CardHeader className="text-center">
<CardTitle className="flex items-center justify-center gap-2">
<AlertTriangle className="h-5 w-5 text-red-500" />
eName verification failed
</CardTitle>
<CardDescription>
eName verification failed
</CardDescription>
</CardHeader>
<CardContent className="text-center space-y-4">
<div className="bg-red-50 p-4 rounded-lg">
<p className="text-red-800 text-sm">
eName Mismatch: It appears that you are trying to sign with the wrong eName.
Please make sure you are signing with the right eID linked to this account.
</p>
</div>
<Button onClick={onCancel} variant="secondary">Close</Button>
</CardContent>
</Card>
);
}

return (
<Card className="w-full max-w-md mx-auto">
<CardHeader className="text-center">
Expand Down
Loading