Skip to content

Conversation

coodos
Copy link
Contributor

@coodos coodos commented Aug 25, 2025

Description of change

Issue Number

Type of change

  • Breaking (any change that would cause existing functionality to not work as expected)
  • New (a change which implements a new feature)
  • Update (a change which updates existing functionality)
  • Fix (a change which fixes an issue)
  • Docs (changes to the documentation)
  • Chore (refactoring, build scripts or anything else that isn't user-facing)

How the change has been tested

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • New Features
    • Deep-link support for blind voting and vote reveal across wallet and eVoting app.
    • Dedicated “Reveal Your Vote” interface with step-by-step guidance.
    • Mobile: one-tap reveal button opens the wallet; Desktop: QR code for reveal.
  • Enhancements
    • Seamless routing from deep links: auto-redirects to login or scanning, and navigates directly to the relevant poll on reveal.
    • More predictable signing behavior: signing modal opens only when appropriate.
    • Improved startup initialization for a smoother experience.

Copy link
Contributor

coderabbitai bot commented Aug 25, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Implements deep-link handling across wallet and eVoting apps: adds blind-vote and reveal flows, async deep-link parsing/dispatch in wallet layout, specialized scan-qr handling for blind-vote/reveal, eVoting reveal deep-link creation, session handoff via sessionStorage, and UI updates to drive and respond to reveal requests.

Changes

Cohort / File(s) Summary
Wallet deep-link management
infrastructure/eid-wallet/src/routes/+layout.svelte
Adds Tauri deep-link integration (initial and ongoing), async URL parsing for auth/sign/reveal, authenticated routing to /scan-qr or /login, sessionStorage persistence of deep-link payloads, global state/biometry init, and refined navigation transitions.
Wallet scan-qr blind-vote/reveal flow
infrastructure/eid-wallet/src/routes/(app)/scan-qr/+page.svelte
Extends deep-link decode to branch for blind-vote and reveal; initializes blind-vote state, opens signing drawer only for regular signing, fetches poll details asynchronously, adds reveal request handling, converts handlers to async, updates event wiring, and adds focused logging/error paths.
eVoting reveal deeplink feature
platforms/eVoting/src/app/(app)/layout.tsx, platforms/eVoting/src/components/blind-voting-interface.tsx, platforms/eVoting/src/lib/utils/mobile-detection.ts
Introduces reveal deep-link utility (w3ds://reveal?pollId=...), UI updates to generate/open QR/button for reveal, session-driven reveal UI override, and app layout listener for deepLinkReveal to navigate to poll and store request metadata.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor U as User
  participant EV as eVoting Web App
  participant DL as Deep Link (w3ds://)
  participant WL as Wallet +layout
  participant SQ as Wallet /scan-qr

  U->>EV: Click "Reveal" (button or scan QR)
  EV->>DL: Open w3ds://reveal?pollId={id}
  DL->>WL: Launch app with URL
  WL->>WL: Parse URL (type=reveal, pollId)
  alt Authenticated
    WL->>WL: Store deepLinkData (sessionStorage)
    WL->>SQ: Navigate to /scan-qr
    SQ->>SQ: Set isRevealRequest, revealPollId
  else Not authenticated
    WL->>WL: Store pendingDeepLink
    WL->>WL: Navigate to /login
  end
Loading
sequenceDiagram
  autonumber
  actor U as User
  participant WL as Wallet +layout
  participant SQ as Wallet /scan-qr
  participant API as Poll API

  Note over WL: Deep link type=sign with payload
  WL->>SQ: Route to /scan-qr with data
  SQ->>SQ: Decode signing data
  alt Blind vote
    SQ->>SQ: Set isBlindVotingRequest, clear errors
    SQ->>SQ: Prepare signingData with placeholder pollDetails
    SQ->>API: Fetch poll details (async)
    API-->>SQ: Poll details (success/fail)
    SQ->>SQ: Update signingData.pollDetails or set error
    SQ->>SQ: Keep drawer state for blind voting
  else Regular signing
    SQ->>SQ: Open signing modal/drawer
  end
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

  • Feat/w3ds evoting #290: Implements related deep-link signing/reveal flows and utilities; overlaps with this PR’s deeplink wiring across wallet and eVoting.
  • chore: signing bug #315: Modifies wallet scan-qr signing logic with real crypto; directly intersects with the new blind-vote/reveal handling here.
  • Feat/evoting reveal vote data #324: Adds complementary deep-link reveal and blind-vote logic across wallet and platform, mirroring this PR’s areas.

Suggested reviewers

  • sosweetham

Poem

A whisk of links, a hop through time,
I nose a w3ds chime.
Blind votes tucked, reveals in sight—
I bound from app to wallet light.
QR fields like clover spread,
Tap, reveal—my paws have led.
Carrots cached, the trail well-read. 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 650aad0 and e7fab71.

⛔ Files ignored due to path filters (4)
  • infrastructure/eid-wallet/src-tauri/gen/android/app/arm64/release/baselineProfiles/0/app-arm64-release.dm is excluded by !**/gen/**
  • infrastructure/eid-wallet/src-tauri/gen/android/app/arm64/release/baselineProfiles/1/app-arm64-release.dm is excluded by !**/gen/**
  • infrastructure/eid-wallet/src-tauri/gen/android/app/arm64/release/eid-w3ds-v0.2.1.0.apk is excluded by !**/gen/**
  • infrastructure/eid-wallet/src-tauri/gen/android/app/arm64/release/output-metadata.json is excluded by !**/gen/**
📒 Files selected for processing (5)
  • infrastructure/eid-wallet/src/routes/(app)/scan-qr/+page.svelte (6 hunks)
  • infrastructure/eid-wallet/src/routes/+layout.svelte (1 hunks)
  • platforms/eVoting/src/app/(app)/layout.tsx (1 hunks)
  • platforms/eVoting/src/components/blind-voting-interface.tsx (4 hunks)
  • platforms/eVoting/src/lib/utils/mobile-detection.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/blindvote-deeplink-bug

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coodos coodos merged commit 731ef80 into main Aug 25, 2025
0 of 4 checks passed
@coodos coodos deleted the fix/blindvote-deeplink-bug branch August 25, 2025 10:31
@coderabbitai coderabbitai bot mentioned this pull request Aug 26, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants