feat(CodePen): Add support for height & width options#146
feat(CodePen): Add support for height & width options#146talohana wants to merge 1 commit intoMichaelDeBoey:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 300 300
Branches 95 96 +1
=========================================
Hits 300 300 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MichaelDeBoey
left a comment
There was a problem hiding this comment.
Hi @talohana! 👋
Thanks for taking the time to implement this feature. 👊
I would however take a look at how the Twitch options are implemented and make them have a default value.
Exposing a defaultOptions value to merge them with the possible given options and pass that object back into the getHTML function is adding unnecessary imo.
I see, it does look simpler, should I make the changes in this PR or create a new one? |
@talohana You can just hard reset this branch onto |
7fd00c4 to
94e0a3e
Compare
|
will this pull request be merged soon? |
I can work on it later today, @MichaelDeBoey any changes required rather than resolving the conflicts? |
e90eb17 to
fbac3f9
Compare
fbac3f9 to
4d96646
Compare
What: Added option to override hardcoded CodePen dimensions, with option to merge provided options with default options
Why: In order to change hardcoded CodePen's iframe width/height
How:
Each transformer can optionally export a
const defaultOptions.When the plugin runs it merges provided options (
services[name]) if exist withdefaultOptionswith precedence of provided options, and passes them as a second argument to the transformer exportedgetHTMLfunctionChecklist: