Skip to content

feat(CodePen): Add support for height & width options #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −5
Open

feat(CodePen): Add support for height & width options #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/__tests__/transformers/CodePen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import cases from 'jest-in-case';

import plugin from '../../';
import { getHTML, shouldTransform } from '../../transformers/CodePen';

import { cache, getMarkdownASTForFile, mdastToHtml } from '../helpers';

cases(
Expand Down Expand Up @@ -79,13 +77,24 @@ cases(
);

test('Gets the correct CodePen iframe', () => {
const html = getHTML('https://codepen.io/team/codepen/pen/PNaGbb');
const html = getHTML('https://codepen.io/team/codepen/pen/PNaGbb', {});

expect(html).toMatchInlineSnapshot(
`<iframe src="https://codepen.io/team/codepen/embed/preview/PNaGbb" style="width:100%; height:300px;"></iframe>`
);
});

test('Gets the correct CodePen iframe with custom dimensions', () => {
const html = getHTML('https://codepen.io/team/codepen/pen/PNaGbb', {
width: '50%',
height: '50%',
});

expect(html).toMatchInlineSnapshot(
`<iframe src="https://codepen.io/team/codepen/embed/preview/PNaGbb" style="width:50%; height:50%;"></iframe>`
);
});

test('Plugin can transform CodePen links', async () => {
const markdownAST = getMarkdownASTForFile('CodePen');

Expand Down
4 changes: 2 additions & 2 deletions src/transformers/CodePen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ export const shouldTransform = (url) => {
);
};

export const getHTML = (url) => {
export const getHTML = (url, { width = '100%', height = '300px' }) => {
const iframeUrl = url.replace('/pen/', '/embed/preview/');

return `<iframe src="${iframeUrl}" style="width:100%; height:300px;"></iframe>`;
return `<iframe src="${iframeUrl}" style="width:${width}; height:${height};"></iframe>`;
};