Skip to content

Fix arithmetic overflow in Test-PasswordQuality with empty dictionary… #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaelGrafnetter merged 1 commit into from
Mar 24, 2026
Merged

Fix arithmetic overflow in Test-PasswordQuality with empty dictionary… #221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Src/DSInternals.PowerShell/Commands/Misc/TestPasswordQualityCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,10 +442,13 @@ private void TestWeakNTHashesFromUnsortedFile()

private void ReportProgress(long fileLength, long position, ProgressRecord progress)
{
if (position >= fileLength)
if (fileLength <= 0 || position >= fileLength)
{
// Report operation completion
progress.RecordType = ProgressRecordType.Completed;
progress.PercentComplete = 100;
this.WriteProgress(progress);
return;
}

// Calculate the current progress
Expand Down
Loading