Fix arithmetic overflow in Test-PasswordQuality with empty dictionary…#221
Merged
MichaelGrafnetter merged 1 commit intomasterfrom Mar 24, 2026
Merged
Fix arithmetic overflow in Test-PasswordQuality with empty dictionary…#221MichaelGrafnetter merged 1 commit intomasterfrom
MichaelGrafnetter merged 1 commit intomasterfrom
Conversation
… file The ReportProgress method would divide by zero when fileLength was 0. Add an early return when fileLength <= 0 to prevent the division. Fixes #219 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an OverflowException in Test-PasswordQuality progress reporting by preventing a divide-by-zero/overflow scenario when the input file length is 0 (empty file), aligning with issue #219.
Changes:
- Add an early return in
ReportProgresswhenfileLength <= 0(or whenposition >= fileLength) to avoid invalid progress calculation. - Ensure progress is marked as completed (
PercentComplete = 100) and written before returning.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… file
The ReportProgress method would divide by zero when fileLength was 0. Add an early return when fileLength <= 0 to prevent the division.
Fixes #219