Setup SSH: adding -4 option only of ForceIP4 is selected #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR conditionally adds the -4 option to SSH commands based on the ForceIPv4 setting, rather than always including it. The changes ensure that IPv4 is only forced when explicitly configured by the user.
- Exposes
ForceIPv4property inSecureShellKeySetupSettingsfor use in SSH command construction - Updates SSH command argument formatting to conditionally include the
-4flag - Removes hardcoded
-4option from SSH key scan and connection commands
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| SecureShellPassphraseDialog.xaml | Removes content (file appears to be cleared or deleted) |
| SecureShellKeySetupSettings.cs | Adds public property to expose the ForceIPv4 setting |
| SecureShellKeySetupService.cs | Updates SSH command construction to conditionally include -4 flag based on ForceIPv4 setting |
| PackageConstants.cs | Modifies SSH argument format strings to support optional -4 flag parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/Extension/RemoteDebuggerLauncher/RemoteOperations/SecureShellKeySetupService.cs
Show resolved
Hide resolved
Contributor
|
@MichaelKoster70 I've opened a new pull request, #96, to work on those changes. Once the pull request is ready, I'll request review from you. |
* Initial plan * Add clarifying comments for SSH format string spacing Co-authored-by: MichaelKoster70 <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: MichaelKoster70 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.