Document intentional spacing in SSH format strings #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: MichaelKoster70 <[email protected]>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Fix extra space in SSH setup based on feedback
Document intentional spacing in SSH format strings
Dec 30, 2025
MichaelKoster70
approved these changes
Dec 30, 2025
MichaelKoster70
added a commit
that referenced
this pull request
Dec 30, 2025
* Adding -4 option only of ForceIPvç is selected * Document intentional spacing in SSH format strings (#96) Co-authored-by: MichaelKoster70 <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: MichaelKoster70 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on PR #95 regarding missing space after format placeholders in SSH argument strings.
The format strings
KeyScanArguments = "{2}-p {1} {0}"andSshArguments = "{0}@{1} {4}-p {2} -i \"{3}\" \"echo DONE\""appear to be missing spaces after{2}and{4}. However, adding spaces would create double-spacing whenForceIPv4is enabled, sinceSshForceIPv4 = "-4 "includes a trailing space.Changes:
<remarks>XML documentation toKeyScanArgumentsandSshArgumentsexplaining the intentional lack of spacing after placeholders that can be replaced withSshForceIPv4This makes the design choice explicit for future maintainers without altering the runtime behavior.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.