recording visible to user

[pooja418]

Recordes session acees right
using visible and read permission now user can see the recording links.

[xJuvi]

There are unclarified questions. I think this PR isn't complete.

[xJuvi]

Why did u remove this?
This is the hint if the current running meeting is recorded or not.

[pooja418]

Oh yes i forgot it the current meeting recording hint should be as it was before.By mistakenly in testing i removed it.

[xJuvi]

You should refactor the whole part. This is only copied fromt he "moderator" section. But in the moderator section, it will be checked, if int he currect BBB object recordings are allowed. This check is missing in your changed.

See:

BigBlueButton-Ilias-Plugin/classes/class.ilObjBigBlueButtonGUI.php

Lines 351 to 358 in 8fba2f4

	if ($values["choose_recording"]){
	$my_tpl->setVariable("recordings", $this->buildRecordingUI());
	$my_tpl->setVariable("Headline_Recordings", $this->txt("Headline_Recordings"));
	$my_tpl->setVariable("checkbox_record_meeting", $this->txt("checkbox_record_meeting"));
	}else{
	$my_tpl->setVariable("CHOOSE_RECORDING_VISIBLE", "hidden");
	}

[pooja418]

Yes in the moderator section, it will be checked, if the current BBB object recordings are allowed. This check is missing in changes because user can't allow for it.Only moderator or admins can allow for the changes to that checkbox if they record Current BBB object or not.

[xJuvi]

Yes that's right. But it also controls if the recordings ui is visible or no. With your change, users can see the recording ui when recordings in the bbb object are disallowed. So i think is should be checked if recordings are allowed.

[pooja418]

Yes it should be like this in if check condition
if ($values["choose_recording"]){
$my_tpl->setVariable("recordings", $this->buildRecordingUI());
$my_tpl->setVariable("Headline_Recordings", $this->txt("Headline_Recordings"));
}

[pooja418]

Hello @xJuvi ,
since it's been a long time.I didn't get any response or comment from your side on this pull request.
May i know what happened here?
If still it has something to do then let me know so i can go further with changes.

[xJuvi]

Hey @pooja418
please add your suggestion as commit to this PR and not as comment inline this.
Then I can better check if it's correct and useful.

Kind regards