Skip to content

recording visible to user #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pooja418 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

recording visible to user #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions classes/class.ilObjBigBlueButtonGUI.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,12 +359,17 @@ public function showContent()
$my_tpl->setVariable("hasMeetingRecordings", $this->has_meeting_recordings && boolval($values["choose_recording"]) ? "true" : "false");

$bbbURL=$BBBHelper->joinURLModerator($this->object);
} else {
}
else {
$my_tpl = new ilTemplate("./Customizing/global/plugins/Services/Repository/RepositoryObject/BigBlueButton/templates/tpl.BigBlueButtonClient.html", true, true);

$my_tpl->setVariable("classNotStartedText", $this->txt("class_not_started_yet"));

$bbbURL=$BBBHelper->joinURL($this->object);

$my_tpl->setVariable("recordings", $this->buildRecordingUI());
Copy link
Contributor

@xJuvi xJuvi Sep 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should refactor the whole part. This is only copied fromt he "moderator" section. But in the moderator section, it will be checked, if int he currect BBB object recordings are allowed. This check is missing in your changed.

See:

BigBlueButton-Ilias-Plugin/classes/class.ilObjBigBlueButtonGUI.php

Lines 351 to 358 in 8fba2f4

if ($values["choose_recording"]){
$my_tpl->setVariable("recordings", $this->buildRecordingUI());
$my_tpl->setVariable("Headline_Recordings", $this->txt("Headline_Recordings"));
$my_tpl->setVariable("checkbox_record_meeting", $this->txt("checkbox_record_meeting"));
}else{
$my_tpl->setVariable("CHOOSE_RECORDING_VISIBLE", "hidden");
}

Copy link
Contributor Author

@pooja418 pooja418 Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes in the moderator section, it will be checked, if the current BBB object recordings are allowed. This check is missing in changes because user can't allow for it.Only moderator or admins can allow for the changes to that checkbox if they record Current BBB object or not.

Copy link
Contributor

@xJuvi xJuvi Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's right. But it also controls if the recordings ui is visible or no. With your change, users can see the recording ui when recordings in the bbb object are disallowed. So i think is should be checked if recordings are allowed.

$my_tpl->setVariable("Headline_Recordings", $this->txt("Headline_Recordings"));

$bbbURL=$BBBHelper->joinURL($this->object);

}

$my_tpl->setVariable("clickToOpenClass", $this->txt("click_to_open_class"));
Expand Down
16 changes: 10 additions & 6 deletions templates/tpl.BigBlueButtonClient.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,7 @@
$('#classNotStarted').show();
}

var isMeetingRecorded={isMeetingRecorded};
Copy link
Contributor

@xJuvi xJuvi Sep 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did u remove this?
This is the hint if the current running meeting is recorded or not.

Copy link
Contributor Author

@pooja418 pooja418 Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes i forgot it the current meeting recording hint should be as it was before.By mistakenly in testing i removed it.

if(isMeetingRecorded){
$('#isMeetingRecorded').show();
}else{
$('#isMeetingRecorded').hide();
}


});
</script>
Expand All @@ -32,5 +27,14 @@
{classNotStartedText}
</div>
<div id="isMeetingRecorded">{meetingRecordedMessage}</div>
<div id="recordings">
<h1><span>{Headline_Recordings}</span></h1>
<div>{recordings}</div>
</div>
<style>
.dropup, .dropdown{
visibility: hidden;
}
</style>