fix: Increase the number of sections for target grouping #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilia3546
requested review from
CognitiveDisson,
aleksandergrzyb,
ecamacho and
polac24
as code owners
| func groupedByTarget() -> IDEActivityLogSection { | ||
| // The only way to know if the structure is flatten is to check the first elements | ||
| // for the `(in target 'ABC' from project Project)` string | ||
| let firstElements = subSections.prefix(15) // we only analyze up to the first 15 subsections |
Collaborator
There was a problem hiding this comment.
Let's change the comment here too or remove it.
fix: Increase the number of section to detect targets to 50
ilia3546
force-pushed
the
fix-target-grouping-check
branch
from
aa99403 to
2a4ca96
Compare
aleksandergrzyb
previously approved these changes
Mar 10, 2025
Signed-off-by: Antoine van der Lee <[email protected]>
Collaborator
|
I'm closing this PR since we're not using any limit anymore in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When we use command xcodebuild build-for-testing with Xcode 16 result .xcactivitylog doesn't contains target markers in first 15 records.
As result target grouping doesn't work properly
Solution:
I have increased the number of number of sections for target grouping from 15 to 50 records.
Result:
Now target grouping works properly with xcodebuild from Xcode 16