Remove duplicate post/pre actions #3122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianv1
force-pushed
the
sebastianv1/fix-dup-actions
branch
2 times, most recently
from
f77a73f to
21f1b06
Compare
When using custom schemes with "same_as_run" for the profile action, I noticed that the build target's pre/post build actions were being duplicated in the generated scheme because we copy the whole build target into the profile action (incl post_actions and pre_actions). This just copies the `id` from the build target instead. Signed-off-by: Sebastian Shanus <[email protected]>
sebastianv1
force-pushed
the
sebastianv1/fix-dup-actions
branch
from
21f1b06 to
7668ec5
Compare
brentleyjones
approved these changes
Jan 8, 2025
brentleyjones
merged commit 8eacfbf
into
MobileNativeFoundation:main
11 of 13 checks passed
karim-alweheshy
pushed a commit
to karim-alweheshy/rules_xcodeproj
that referenced
this pull request
Mar 6, 2025
When using custom schemes with "same_as_run" for the profile action, I noticed that the build target's pre/post build actions were being duplicated in the generated scheme because we copy the whole build target into the profile action (incl post_actions and pre_actions). This just copies the `id` from the build target instead. Signed-off-by: Sebastian Shanus <[email protected]> Signed-off-by: Karim Alweheshy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using custom schemes with "same_as_run" for the profile action, I noticed that the build target's pre/post build actions were being duplicated in the generated scheme because we copy the whole build target into the profile action (incl post_actions and pre_actions).
This just copies the
idfrom the build target instead.