Skip to content

Remove duplicate post/pre actions #3122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brentleyjones merged 1 commit into from
Jan 8, 2025
Merged

Remove duplicate post/pre actions #3122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions test/internal/xcschemes/infos_from_json_tests.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,8 @@ def infos_from_json_test_suite(name):
],
),
]
expected_id_full_launch_build_targets = [xcscheme_infos_testable.make_build_target(t.id) for t in expected_full_launch_build_targets]
expected_id_full_build_targets = [xcscheme_infos_testable.make_build_target(t.id) for t in expected_full_build_targets]

# Empty

Expand Down Expand Up @@ -605,8 +607,8 @@ def infos_from_json_test_suite(name):
name = "A scheme",
profile = xcscheme_infos_testable.make_profile(
build_targets = (
expected_full_launch_build_targets +
expected_full_build_targets
expected_id_full_launch_build_targets +
expected_id_full_build_targets
),
env_include_defaults = "0",
launch_target = expected_profile_same_as_run_launch_target,
Expand Down Expand Up @@ -791,7 +793,7 @@ def infos_from_json_test_suite(name):
xcscheme_infos_testable.make_scheme(
name = "A scheme",
profile = xcscheme_infos_testable.make_profile(
build_targets = expected_full_build_targets,
build_targets = expected_id_full_build_targets,
env_include_defaults = "0",
launch_target = expected_profile_same_as_run_launch_path,
),
Expand Down
2 changes: 1 addition & 1 deletion xcodeproj/internal/xcschemes/xcscheme_infos.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ def _profile_info_from_dict(
top_level_deps):
if profile == "same_as_run":
return _make_profile(
build_targets = run.build_targets,
build_targets = [_make_build_target(t.id) for t in run.build_targets],
launch_target = _make_same_as_run_launch_target(
run.launch_target,
),
Expand Down
Loading