feat: 177 update maven groupid and repository license #186
Conversation
|
|
|
|
.github/workflows/release.yml
Outdated
| @@ -0,0 +1,39 @@ | |||
| name: Build and Release | |||
There was a problem hiding this comment.
Let's address this in a different issue/PR. There is some clean-up to be done. This repository is set for release with the previous org details, more info
| <groupId>org.mobilitydata</groupId> | ||
| <artifactId>gbfs-validator-java-parent</artifactId> | ||
| <version>2.0.67-SNAPSHOT</version> | ||
| <version>2.0.67</version> |
There was a problem hiding this comment.
Are you sure we should change this by hand?
Actually I looked into it and the version is automatically set by entur/gha-maven-central/.github/workflows/maven-publish.yml
I suggest we don't change it by hand.
There was a problem hiding this comment.
I thought I needed to do a release so I changed it. I'll leave it there and let the github actions change it next time.
There was a problem hiding this comment.
Maybe it will work.
I saw that entur/gha-maven-central does something special if the current version in pom.xml ends with SNAPSHOT (see this), but I am not sure of the exact effect.
There was a problem hiding this comment.
This is why my suggestion is to address the release in its own issue; we also need to "clean up" the maven build, dependencies, release, and other entur's related plugins.
Uh oh!
There was an error while loading. Please reload this page.