feat: 177 update maven groupid and repository license #186
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| name: Build and Release | ||
|
|
||
| on: | ||
| push: | ||
| tags: | ||
| - 'v*.*.*' | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Set up JDK | ||
| uses: actions/setup-java@v3 | ||
| with: | ||
| java-version: '17' | ||
| distribution: 'temurin' | ||
|
|
||
| - name: Build with Maven | ||
| run: mvn clean install | ||
|
|
||
| release: | ||
| needs: build | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Create GitHub Release | ||
| uses: softprops/action-gh-release@v1 | ||
| with: | ||
| files: | | ||
| target/*.jar | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,9 +3,9 @@ | |
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
| <parent> | ||
| <groupId>org.mobilitydata</groupId> | ||
| <artifactId>gbfs-validator-java-parent</artifactId> | ||
| <version>2.0.67</version> | ||
|
There was a problem hiding this comment. Are you sure we should change this by hand?
Contributor
Author
There was a problem hiding this comment. I thought I needed to do a release so I changed it. I'll leave it there and let the github actions change it next time. There was a problem hiding this comment. Maybe it will work.
Member
There was a problem hiding this comment. This is why my suggestion is to address the release in its own issue; we also need to "clean up" the maven build, dependencies, release, and other entur's related plugins. |
||
| </parent> | ||
|
|
||
| <artifactId>gbfs-validator-java-api</artifactId> | ||
|
|
@@ -14,12 +14,18 @@ | |
| <url>https://github.com/entur/gbfs-validator-java</url> | ||
| <licenses> | ||
| <license> | ||
| <name>Apache License, Version 2.0</name> | ||
| <url>https://joinup.ec.europa.eu/software/page/eupl</url> | ||
| <distribution>repo</distribution> | ||
| </license> | ||
| </licenses> | ||
| <developers> | ||
| <developer> | ||
| <name>MobilityData</name> | ||
| <email>developers@mobilitydata.org</email> | ||
| <organization>MobilityData</organization> | ||
| <organizationUrl>https://mobilitydata.org/</organizationUrl> | ||
| </developer> | ||
| <developer> | ||
| <name>Tom Erik Støwer</name> | ||
| <email>tom.erik.stower@entur.org</email> | ||
|
|
@@ -28,9 +34,9 @@ | |
| </developer> | ||
| </developers> | ||
| <scm> | ||
| <connection>scm:git:ssh://git@github.com/MobilityData/gbfs-validator-java.git</connection> | ||
| <developerConnection>scm:git:ssh://git@github.com/MobilityData/gbfs-validator-java.git</developerConnection> | ||
| <url>https://github.com/MobilityData/gbfs-validator-java.git</url> | ||
| <tag>HEAD</tag> | ||
| </scm> | ||
| <properties> | ||
|
|
@@ -126,15 +132,15 @@ | |
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>org.mobilitydata</groupId> | ||
| <artifactId>gbfs-validator-java-loader</artifactId> | ||
| <version>2.0.67</version> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>org.mobilitydata</groupId> | ||
| <artifactId>gbfs-validator-java</artifactId> | ||
| <version>2.0.67</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.google.guava</groupId> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's address this in a different issue/PR. There is some clean-up to be done. This repository is set for release with the previous org details, more info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted.