-
Notifications
You must be signed in to change notification settings - Fork 6
Fix: various adjustments #855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-855-ejk2938k.web.app |
| sx={{ fontWeight: 700 }} | ||
| > | ||
| {t('feeds')} | ||
| <Box sx={{ maxWidth: '1600px', mx: 'auto', width: '100%' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[question]: Are we planning, at some point, to have most of these style changes in a CSS/theme location?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I will explore this in my style POC side car. To determine what should go in the theme and what should be a style local to the component, and how we organize these styles
davidgamez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary:
Various small adjustments in the Web-App
Sign-In page
Feed Detail page
Home page
Feeds search page
General
Expected behavior:
On feeds page when scrolling down the search bar should be sticky. Also back navigation when feature selecting should be working as well
Testing tips:
tldfeeds exfeeds/tld-823and see the page workingPlease make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything