Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds documentation container deployment to the existing Docker workflow. It introduces a new build job for creating a docs Docker image and updates the deployment process to include starting the docs container.
- Adds a new
build-docsjob that builds a Docker image for documentation - Updates the
deployjob dependencies to include the new docs build - Adds a deployment step to start the docs container on port 4173
| deploy: | ||
| runs-on: ${{ fromJson(inputs.runner_label_json) }} | ||
| needs: [ build-main, build-data-process, build-web ] | ||
| needs: [ build-main, build-data-process, build-web, build-docs ] |
There was a problem hiding this comment.
[nitpick] The deploy job now depends on all build jobs including the new build-docs. Consider whether the docs container deployment should be independent of the main application deployment to avoid blocking the entire deployment if docs build fails.
| needs: [ build-main, build-data-process, build-web, build-docs ] | |
| needs: [ build-main, build-data-process, build-web ] |
| run: | | ||
| docker stop nexent-docs 2>/dev/null || true | ||
| docker rm nexent-docs 2>/dev/null || true | ||
| docker run -d --name nexent-docs -p 4173:4173 nexent/nexent-docs |
There was a problem hiding this comment.
The docs container is started without restart policy or health checks. Consider adding --restart=unless-stopped and other production-ready flags for better reliability.
| docker run -d --name nexent-docs -p 4173:4173 nexent/nexent-docs | |
| docker run -d --name nexent-docs --restart=unless-stopped \ |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
#714 🔨 Add docs container deployment.