Skip to content

🔨 Add docs container deployment. #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Phinease merged 1 commit into from
Aug 6, 2025
Merged

🔨 Add docs container deployment. #746

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion .github/workflows/docker-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,20 @@ jobs:
- name: Build web frontend image
run: docker build --build-arg MIRROR=https://registry.npmmirror.com -t nexent/nexent-web -f make/web/Dockerfile .

build-docs:
runs-on: ${{ fromJson(inputs.runner_label_json) }}
steps:
- name: Checkout code
uses: actions/checkout@v4
with:
fetch-depth: 1
retries: 3
- name: Build docs image
run: docker build --progress=plain -t nexent/nexent-docs -f make/docs/Dockerfile .

deploy:
runs-on: ${{ fromJson(inputs.runner_label_json) }}
needs: [ build-main, build-data-process, build-web ]
needs: [ build-main, build-data-process, build-web, build-docs ]
Copy link

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The deploy job now depends on all build jobs including the new build-docs. Consider whether the docs container deployment should be independent of the main application deployment to avoid blocking the entire deployment if docs build fails.

Suggested change
needs: [ build-main, build-data-process, build-web, build-docs ]
needs: [ build-main, build-data-process, build-web ]

Copilot uses AI. Check for mistakes.
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand All @@ -80,6 +91,11 @@ jobs:
rm -rf $HOME/nexent
mkdir -p $HOME/nexent
cp -r $GITHUB_WORKSPACE/* $HOME/nexent/
- name: Start docs container
run: |
docker stop nexent-docs 2>/dev/null || true
docker rm nexent-docs 2>/dev/null || true
docker run -d --name nexent-docs -p 4173:4173 nexent/nexent-docs
Copy link

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs container is started without restart policy or health checks. Consider adding --restart=unless-stopped and other production-ready flags for better reliability.

Suggested change
docker run -d --name nexent-docs -p 4173:4173 nexent/nexent-docs
docker run -d --name nexent-docs --restart=unless-stopped \

Copilot uses AI. Check for mistakes.
- name: Ensure deploy.sh is executable
run: chmod +x $HOME/nexent/docker/deploy.sh
- name: Deploy with deploy.sh
Expand Down
Loading