Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ucm/integration/vllm/ucm_connector.py
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@ def _create_store(
config["block_size"] = chunk_block_size
if self.is_dsa or self.is_mla:
config["share_buffer_enable"] = True
config["local_rank_size"] = self.tp_size
else:
config["share_buffer_enable"] = False
store = UcmConnectorFactoryV1.create_connector(name, config)
Expand Down
2 changes: 1 addition & 1 deletion ucm/store/pcstore/cc/domain/file/ifile.h
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class IFile {
using FileStat = struct stat64;

public:
IFile(const std::string& path) : path_{path} {}
explicit IFile(const std::string& path) : path_{path} {}
virtual ~IFile() = default;
const std::string& Path() const { return this->path_; }
virtual Status MkDir() = 0;
Expand Down
2 changes: 1 addition & 1 deletion ucm/store/pcstore/cc/domain/file/posix_file.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ namespace UC {

class PosixFile : public IFile {
public:
PosixFile(const std::string& path) : IFile{path}, handle_{-1} {}
explicit PosixFile(const std::string& path) : IFile{path}, handle_{-1} {}
~PosixFile() override;
Status MkDir() override;
Status RmDir() override;
Expand Down
1 change: 1 addition & 0 deletions ucm/store/pcstore/cc/domain/trans/share_buffer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ void CleanUpShmFileExceptMe(const std::string& me)
if (now - lwt <= keepThreshold) { continue; }
fs::remove(path);
} catch (...) {
// Ignore filesystem errors;
}
}
}
Expand Down