[fix]clean code and set local_rank_size to tp_size #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qyh111
requested review from
harrisonyhq,
hek14,
mag1c-h and
ygwpz
as code owners
mag1c-h
approved these changes
Dec 27, 2025
zhou-haitao
approved these changes
Dec 27, 2025
qyh111
added a commit
to qyh111/unified-cache-management
that referenced
this pull request
Dec 29, 2025
…#596) clean code and set local_rank_size to tp_size
qyh111
added a commit
to qyh111/unified-cache-management
that referenced
this pull request
Dec 29, 2025
…#596) clean code and set local_rank_size to tp_size
ygwpz
pushed a commit
that referenced
this pull request
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
clean code and set local_rank_size to tp_size
Modifications
set local_rank_size to tp_size
fix clean code
Test
example works fine for both qwen and ds
The local rank size is set to the expected value even though it is not explicitly configured or shown in the configuration file.