add exception log for httpserver.

[hiworldwzj]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @hiworldwzj, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the stability and observability of the httpserver component by adding robust exception logging. It specifically targets the handle_loop asynchronous function, which is responsible for processing and managing output tokens for ongoing requests. By wrapping the critical processing logic in a try-except block, the system will now automatically log detailed information about any unexpected errors, making it much easier to identify, debug, and resolve issues that might arise during request handling.

Highlights

• Exception Handling Improvement: Implemented a try-except block around the core request processing loop within the handle_loop function in lightllm/server/httpserver/manager.py to catch and log BaseException instances.
• Enhanced Debuggability: Added logger.exception(str(e)) to ensure that detailed stack traces are logged when an exception occurs, significantly aiding in the diagnosis of runtime issues.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds exception logging to the handle_loop in the httpserver to improve robustness and observability. The core change involves wrapping the request processing logic in a try...except block. I suggest refining the exception handling to align with Python best practices, specifically by catching a more appropriate exception type and enhancing the log message for better clarity.

[gemini-code-assist]

It's a Python best practice to catch the more specific Exception class instead of BaseException¹. BaseException includes system-exiting exceptions like SystemExit and KeyboardInterrupt, and catching them can interfere with graceful process termination. Also, logger.exception automatically includes the exception details and traceback, so no need to pass str(e) as an argument. A bare raise statement re-raises the original exception while preserving its full stack trace.

Style Guide References

Suggested change

	except BaseException as e:
	logger.exception(str(e))
	raise e
	except Exception as e:
	logger.exception("An unexpected error occurred in the httpserver handle_loop")
	raise

Footnotes

1. Catch Exception instead of BaseException. (link) ↩