Skip to content

add exception log for httpserver. #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hiworldwzj merged 1 commit into from
Jul 24, 2025
Merged

add exception log for httpserver. #987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 46 additions & 42 deletions lightllm/server/httpserver/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,50 +645,54 @@ async def handle_loop(self):
except asyncio.TimeoutError:
pass

for group_req_id_ in list(self.req_id_to_out_inf.keys()):
req_status = self.req_id_to_out_inf.get(group_req_id_, None)
if req_status is None:
continue
try:
for group_req_id_ in list(self.req_id_to_out_inf.keys()):
req_status = self.req_id_to_out_inf.get(group_req_id_, None)
if req_status is None:
continue

token_list = []
for req in req_status.group_req_objs.shm_req_objs:
req_id = req.request_id
read_token_count = 1
if req.out_tokens_queue.is_full():
read_token_count = LIGHTLLM_OUT_TOKEN_QUEUE_SIZE

for _ in range(read_token_count):
if not req.out_tokens_queue.is_empty():

text, src_index, special, count_output_tokens = req.out_tokens_queue.peek()
req.cumlogprob += float(req.shm_logprobs.arr[src_index])
metadata = {
"id": int(req.shm_prompt_ids.arr[src_index]),
"logprob": float(req.shm_logprobs.arr[src_index]),
"cumlogprob": float(req.cumlogprob) / count_output_tokens,
"special": special,
"count_output_tokens": count_output_tokens,
"prompt_cache_len": req.prompt_cache_len,
"mtp_accepted_token_num": req.mtp_accepted_token_num,
}
if self.args.return_all_prompt_logprobs:
metadata.update(req.get_all_prompt_metadata())
if self.args.use_reward_model:
metadata["score"] = float(req.reward_score)

req.out_tokens_queue.pop_no_ret()

if req.finish_token_index != src_index:
token_list.append((req_id, text, metadata, FinishStatus()))
token_list = []
for req in req_status.group_req_objs.shm_req_objs:
req_id = req.request_id
read_token_count = 1
if req.out_tokens_queue.is_full():
read_token_count = LIGHTLLM_OUT_TOKEN_QUEUE_SIZE

for _ in range(read_token_count):
if not req.out_tokens_queue.is_empty():

text, src_index, special, count_output_tokens = req.out_tokens_queue.peek()
req.cumlogprob += float(req.shm_logprobs.arr[src_index])
metadata = {
"id": int(req.shm_prompt_ids.arr[src_index]),
"logprob": float(req.shm_logprobs.arr[src_index]),
"cumlogprob": float(req.cumlogprob) / count_output_tokens,
"special": special,
"count_output_tokens": count_output_tokens,
"prompt_cache_len": req.prompt_cache_len,
"mtp_accepted_token_num": req.mtp_accepted_token_num,
}
if self.args.return_all_prompt_logprobs:
metadata.update(req.get_all_prompt_metadata())
if self.args.use_reward_model:
metadata["score"] = float(req.reward_score)

req.out_tokens_queue.pop_no_ret()

if req.finish_token_index != src_index:
token_list.append((req_id, text, metadata, FinishStatus()))
else:
finish_status = FinishStatus(req.finish_status.status)
token_list.append((req_id, text, metadata, finish_status))
else:
finish_status = FinishStatus(req.finish_status.status)
token_list.append((req_id, text, metadata, finish_status))
else:
break

async with req_status.lock:
req_status.out_token_info_list.extend(token_list)
req_status.event.set()
break

async with req_status.lock:
req_status.out_token_info_list.extend(token_list)
req_status.event.set()
except BaseException as e:
logger.exception(str(e))
raise e
Comment on lines +693 to +695
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

It's a Python best practice to catch the more specific Exception class instead of BaseException1. BaseException includes system-exiting exceptions like SystemExit and KeyboardInterrupt, and catching them can interfere with graceful process termination. Also, logger.exception automatically includes the exception details and traceback, so no need to pass str(e) as an argument. A bare raise statement re-raises the original exception while preserving its full stack trace.

Style Guide References

Suggested change
except BaseException as e:
logger.exception(str(e))
raise e
except Exception as e:
logger.exception("An unexpected error occurred in the httpserver handle_loop")
raise

Footnotes

  1. Catch Exception instead of BaseException. (link) ↩


self.recycle_event.set()
return
Expand Down