Update translations from Weblate #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The linked discussion is about adding documentation; we can link to that documentation once it's added.
…age" The API doc is being updated to distinguish the current "image preview" content node from a new one, "image element presented in Markdown syntax", which I think we'll just call "inline image". See PR in progress: zulip/zulip#36226 Related: zulip#1913
This commit is the result of the following commands: flutter pub upgrade --major-versions firebase_messaging firebase_core tools/upgrade pod Changelogs: https://pub.dev/packages/firebase_core/changelog#420 https://pub.dev/packages/firebase_messaging/changelog#1603 Notable changes include bump to Firebase Android BoM (34.1.0 to 34.4.0) and Firebase iOS SDK (12.2.0 to 12.4.0), changelog for those are at: https://firebase.google.com/support/release-notes/android https://firebase.google.com/support/release-notes/ios For Android SDK, no notable changes in the FCM component. For iOS SDK, no changes in the FCM component.
This commit is the result of the following commands: flutter pub upgrade --major-versions pigeon tools/check --all-files --fix pigeon Changelog: https://pub.dev/packages/pigeon/changelog#2602 There is one change related `@ProxyApi` which we do not use, and one about improvements to logging errors.
This commit is the result of the following commands: flutter pub upgrade --major-versions drift drift_dev tools/check --all-files --fix drift Changelog: https://pub.dev/packages/drift/changelog#2290 https://pub.dev/packages/drift_dev/changelog#2290
To match our `android/app/build.gradle`, and it is similar to a change earlier this year for Flutter's first-party plugins: flutter/packages@bfad6b976
This is related to zulip#1804, and does the same migration for zulip_plugin.
…review This kind of URL is already covered in the tests of *clusters* of image previews, but it seems helpful to isolate it like this with its own comment. We're also about to add a third variant, testing that we accept images generated with an arbitrary CAMO_URI, which actually we don't currently do, so that'll be a regression test.
…O_URI See discussion: https://chat.zulip.org/#narrow/channel/412-api-documentation/topic/documenting.20inline.20images/near/2279454 We already test the `src == href` case, as ContentExample.imagePreviewSingleNoThumbnail, but I added a test case for an arbitrary CAMO_URI that fails before this commit.
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
fb20751 to
9ef1382
Compare
We'll use this for zulip#1798 to check whether we're sending a message to an unsubscribed channel.
We're about to show a stack trace in an error dialog, and it'll be easier to read when start-aligned than center-aligned. Applying it here with DefaultTextStyle, rather than on each Text widget, to avoid repetition, particularly because one caller (of _adaptiveContent) passes multiple Text widgets and we'd have to handle each of those; that's in UpgradeWelcomeDialog.
(The comment about log entries being truncated at 1 kiB is copied from a similar debugLog call.) Issue zulip#1083 isn't completely fixed here; we'd still like to show stack traces for malformed `/register` responses. Fixes-partly: zulip#1083
(Except when we get a SocketException, which is common when the device is asleep.) This includes showing a stack trace when the /register response is malformed, so I think that's the last of zulip#1083, having addressed events in a recent commit. Fixes zulip#890. Fixes zulip#1083.
Fixes zulip#1898. In general, our policy for supporting old OS versions is described here (in the legacy app's repo, but it applies equally to this app): https://github.com/zulip/zulip-mobile/blob/eb8505c4a/docs/architecture/platform-versions.md So for versions old enough that they represent a very small fraction of our overall user base, we don't have the resources to actively maintain support; but if the app works on those versions, we leave them supported in the app's metadata. When we increased the minimum to Android 9, the reason was that we weren't sure whether things would break on older Android versions, and just didn't have a device older than Android 9 to test on: https://chat.zulip.org/#narrow/channel/243-mobile-team/topic/flutter.3A.20Java.20versions.3F/near/1775991 But in zulip#1898 we've learned that the app does in fact work on Android 8. So restore that support in the app's manifest.
Make sure every row is at least 44px in height by specifying BoxConstraints(minHeight: 44) to meet touch target requirement.
Make the All Channels Page consistent with the Channel Page, as navigating to channel feed and opening the bottom sheet currently uses the three-dot menu icon, which differs from the gesture pattern used in the Channel Page. Fixes part of zulip#1914
Previously, long name could span multiple lines when the system font size was large, causing the row height to become insconsistent with other items. Limiting the name to a single line ensures consistent row height, similar to how it's done on the Channel Page. Fixes zulip#1914
Following a new Figma frame that specifies larger text for the first part: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=11194-18392&m=dev
This makes the caller a bit more verbose, but we're about to make it simpler than it was before.
This makes the caller a bit more verbose, but we're about to make it simpler than it was before.
There are several places where we switch on EmojiDisplay, mostly with TODOs to factor the switch out to something central. Here's a widget to accomplish that factoring, used first in ReactionChip.
…quare Instead of laying out - just padding, in the case where the network request failed, and - nothing, in the case where the URL didn't parse.
Thanks to Greg for pointing this out: zulip#1912 (comment)
It's way more common to be using the app with subscribed channels than unsubscribed channels, so we might as well test with subscribed channels except where we specifically want to check behavior for unsubscribed channels.
Like we did in the compose-box tests in the previous commit.
This fixes the "fourth buggy behavior" in zulip#1798: zulip#1798 (comment) Fixes-partly: zulip#1798
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
9ef1382 to
19dd4ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action