Skip to content

Conversation

@github-actions
Copy link

Automated changes by create-pull-request GitHub action

chrisbobbe and others added 16 commits October 20, 2025 14:05
The linked discussion is about adding documentation; we can link to
that documentation once it's added.
…age"

The API doc is being updated to distinguish the current "image
preview" content node from a new one, "image element presented in
Markdown syntax", which I think we'll just call "inline image". See
PR in progress: zulip/zulip#36226

Related: zulip#1913
This commit is the result of the following commands:
  flutter pub upgrade --major-versions firebase_messaging firebase_core
  tools/upgrade pod

Changelogs:
  https://pub.dev/packages/firebase_core/changelog#420
  https://pub.dev/packages/firebase_messaging/changelog#1603

Notable changes include bump to Firebase Android BoM (34.1.0 to 34.4.0)
and Firebase iOS SDK (12.2.0 to 12.4.0), changelog for those are at:
  https://firebase.google.com/support/release-notes/android
  https://firebase.google.com/support/release-notes/ios

For Android SDK, no notable changes in the FCM component.

For iOS SDK, no changes in the FCM component.
This commit is the result of the following commands:
  flutter pub upgrade --major-versions pigeon
  tools/check --all-files --fix pigeon

Changelog:
  https://pub.dev/packages/pigeon/changelog#2602

There is one change related `@ProxyApi` which we do not use,
and one about improvements to logging errors.
This commit is the result of the following commands:
  flutter pub upgrade --major-versions drift drift_dev
  tools/check --all-files --fix drift

Changelog:
  https://pub.dev/packages/drift/changelog#2290
  https://pub.dev/packages/drift_dev/changelog#2290
To match our `android/app/build.gradle`, and it is similar to a
change earlier this year for Flutter's first-party plugins:
  flutter/packages@bfad6b976
This is related to zulip#1804, and does the same migration for zulip_plugin.
…review

This kind of URL is already covered in the tests of *clusters* of
image previews, but it seems helpful to isolate it like this with
its own comment.

We're also about to add a third variant, testing that we accept
images generated with an arbitrary CAMO_URI, which actually we don't
currently do, so that'll be a regression test.
…O_URI

See discussion:
  https://chat.zulip.org/#narrow/channel/412-api-documentation/topic/documenting.20inline.20images/near/2279454

We already test the `src == href` case, as
ContentExample.imagePreviewSingleNoThumbnail, but I added a test
case for an arbitrary CAMO_URI that fails before this commit.
@github-actions github-actions bot force-pushed the update-translations/weblate branch from fb20751 to 9ef1382 Compare October 27, 2025 10:13
chrisbobbe and others added 13 commits October 30, 2025 13:24
Discovered while testing out `discarded_futures` for zulip#731.

Related: zulip#731
We'll use this for zulip#1798 to check whether we're sending a message to
an unsubscribed channel.
We're about to show a stack trace in an error dialog, and it'll be
easier to read when start-aligned than center-aligned.

Applying it here with DefaultTextStyle, rather than on each Text
widget, to avoid repetition, particularly because one caller (of
_adaptiveContent) passes multiple Text widgets and we'd have to
handle each of those; that's in UpgradeWelcomeDialog.
(The comment about log entries being truncated at 1 kiB is copied
from a similar debugLog call.)

Issue zulip#1083 isn't completely fixed here; we'd still like to show
stack traces for malformed `/register` responses.

Fixes-partly: zulip#1083
(Except when we get a SocketException, which is common when the
device is asleep.)

This includes showing a stack trace when the /register response is
malformed, so I think that's the last of zulip#1083, having addressed
events in a recent commit.

Fixes zulip#890.
Fixes zulip#1083.
Fixes zulip#1898.

In general, our policy for supporting old OS versions is
described here (in the legacy app's repo, but it applies equally
to this app):
  https://github.com/zulip/zulip-mobile/blob/eb8505c4a/docs/architecture/platform-versions.md

So for versions old enough that they represent a very small fraction
of our overall user base, we don't have the resources to actively
maintain support; but if the app works on those versions, we leave
them supported in the app's metadata.

When we increased the minimum to Android 9, the reason was that we
weren't sure whether things would break on older Android versions,
and just didn't have a device older than Android 9 to test on:
  https://chat.zulip.org/#narrow/channel/243-mobile-team/topic/flutter.3A.20Java.20versions.3F/near/1775991

But in zulip#1898 we've learned that the app does in fact work on
Android 8.  So restore that support in the app's manifest.
Make sure every row is at least 44px in height by specifying
BoxConstraints(minHeight: 44) to meet touch target requirement.
Make the All Channels Page consistent with the Channel Page, as
navigating to channel feed and opening the bottom sheet currently
uses the three-dot menu icon, which differs from the gesture pattern
used in the Channel Page.

Fixes part of zulip#1914
Previously, long name could span multiple lines when the system font
size was large, causing the row height to become insconsistent with
other items. Limiting the name to a single line ensures consistent
row height, similar to how it's done on the Channel Page.

Fixes zulip#1914
This makes the caller a bit more verbose, but we're about to make it
simpler than it was before.
chrisbobbe and others added 13 commits October 31, 2025 17:13
It's way more common to be using the app with subscribed channels
than unsubscribed channels, so we might as well test with subscribed
channels except where we specifically want to check behavior for
unsubscribed channels.
Like we did in the compose-box tests in the previous commit.
This is only used with image emojis, for now, but it'll also be
useful for zulip#1936, suppressing image animations in image previews.

Related: zulip#1936
@github-actions github-actions bot force-pushed the update-translations/weblate branch from 9ef1382 to 19dd4ed Compare November 3, 2025 10:13
sm-sayedi and others added 15 commits November 3, 2025 13:25
The "Channels" page and "Inbox" page both have updated designs in
Figma, which we should follow.

This commit matches the badges on the "Channels" page to that new
design. There's more work to match the badges on the "Inbox" page,
but now that work is defined crisply in a TODO:

  // TODO support the "kind=quantity" variant, update dartdoc

Related: zulip#1406
Related: zulip#1527
The private widget, following the Figma, made the badge a bit more
compact, with 1px less padding on each side, and a font size smaller
by 1 (but with the same line height).

That was helpful for keeping the rows at uniform height regardless
of unreads (without text scaling anyway)...but I've accomplished
that by adding a minimum row height (40), in the previous commit.
If Weblate has failed to rebase atop the latest tip, we would rather
have the shared commit history with which to construct a (slightly
out-of-date) PR, than fail because we can't fetch the `weblate`
repository because we don't have any shared history.
@github-actions github-actions bot force-pushed the update-translations/weblate branch from 19dd4ed to d2396b5 Compare November 10, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants