fix: add missing idx parameter to communication-direct-agency redirect#2123
Open
labradorite-dev wants to merge 2 commits intoMuckRock:masterfrom
Open
fix: add missing idx parameter to communication-direct-agency redirect#2123labradorite-dev wants to merge 2 commits intoMuckRock:masterfrom
labradorite-dev wants to merge 2 commits intoMuckRock:masterfrom
Conversation
Fixes NoReverseMatch error when agency users request email login links for embargoed requests. The redirect after sending the login link was missing the required idx parameter for the URL pattern. - Add idx=self.object.pk to redirect in FOIACommunicationDirectAgencyView.form_valid() - Add TestCommunicationViews test class to verify redirect includes idx parameter Fixes MuckRock#2096
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2096
Summary
Fixes NoReverseMatch error when agency users request email login links for embargoed requests.
Changes
idx=self.object.pkparameter to redirect inFOIACommunicationDirectAgencyView.form_valid()TestCommunicationViewsto verify redirect includes idx parameterTesting
form_valid()returns correct redirect URL with idx parameter/respond/{idx}/