fix: add missing idx parameter to communication-direct-agency redirect

muckrock/foia/tests/test_views.py

@@ -53,6 +53,7 @@
     crowdfund_request,
     raw,
 )
+from muckrock.foia.views.communications import FOIACommunicationDirectAgencyView
 from muckrock.jurisdiction.factories import ExampleAppealFactory
 from muckrock.jurisdiction.models import Appeal
 from muckrock.project.forms import ProjectManagerForm
@@ -1256,3 +1257,29 @@ def test_composer_detail_multi_submitted(self):
         )
         assert response.status_code == 200
         assert response.template_name == ["foia/foiacomposer_detail.html"]
+
+
+class TestCommunicationViews(TestCase):
+    """Tests for communication-related views"""
+
+    def setUp(self):
+        """Set up tests"""
+        self.factory = RequestFactory()
+        self.comm = FOIACommunicationFactory()
+
+    def test_direct_agency_email_link_redirect(self):
+        """Test that form_valid redirects with idx parameter after sending email link"""
+        from muckrock.foia.forms.comms import AgencyEmailLinkForm
+        from unittest.mock import Mock
+
+        form = Mock(spec=AgencyEmailLinkForm)
+        form.send_link = Mock()
+
+        view = FOIACommunicationDirectAgencyView()
+        view.object = self.comm
+
+        response = view.form_valid(form)
+
+        form.send_link.assert_called_once()
+        assert response.status_code == 302
+        assert response.url == f"/respond/{self.comm.pk}/"

muckrock/foia/views/communications.py

@@ -73,7 +73,7 @@ def post(self, request, *args, **kwargs):
     def form_valid(self, form):
         """Send the email the login link"""
         form.send_link()
-        return redirect("communication-direct-agency")
+        return redirect("communication-direct-agency", idx=self.object.pk)
 
     def get_form_kwargs(self):
         """Pass the request to the form"""