Skip to content

Improves organization permissions checks#582

Open
allanlasser wants to merge 7 commits intomasterfrom
allanlasser/issue571
Open

Improves organization permissions checks#582
allanlasser wants to merge 7 commits intomasterfrom
allanlasser/issue571

Conversation

@allanlasser
Copy link
Member

@allanlasser allanlasser commented Feb 11, 2026

  • Adds can_manage_members, can_view_members, can_view_subscription, can_edit_subscrpition, can_view_charge and can_review_change_requests permissions for member management page and template rendering, instead of relying on broad is_staff check.

This also includes some improvements for our rules-based permissions system:

  • adds a deny_if_not_obj for improved predicate behavior when object is None
  • documents how contributors can add new permissions in docs/contributors/permissions.md.

While working on this, I opened #586 after realizing we need to do dual-permission checking.

@duckduckgrayduck
Copy link
Contributor

duckduckgrayduck commented Feb 13, 2026

I want to note that this will likely require of us by default to grant the Customer Support Specialist account we have allocated on staging all new permissions for when we want support to test stuff before pushing to production and also have some centralized place where someone in leadership is recording these permissions and who has certain permissions so that we don't make the wrong assumptions about who has access to certain permissions when we ask them to test something on production itself or we ask them to do a task and they can't. This is especially true given we are moving away from is_staff to a more granular access control matrix. Perhaps this is solvable by groups - someone in editorial may not need any of these permissions ever, but support does

@allanlasser
Copy link
Member Author

Yeah, setting up our groups correctly on staging will go a long way here, since every review app copies its database and setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor org page permissions to use groups

2 participants