Skip to content

Conversation

@sayalaruano
Copy link
Collaborator

No description provided.

pip install -e .[docs]
- name: Split README into sections
run: |
python docs/split_readme.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not be done on Sphinx though!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to preprocess he md files first, and then use them in the Sphinx index, is it not the correct way to do it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's correct. but I wanted to highlight that this has no effect on sphinx. We can have a look at it together tomorrow.

@sayalaruano sayalaruano marked this pull request as ready for review April 30, 2025 07:14
@sayalaruano
Copy link
Collaborator Author

This PR closes #79

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the sphinx-apidoc command here also needed considering it's also done on the sphinx conf.py?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This action just tests that the execution works. As the index.md expects some file under references, it is needed here.

@sayalaruano sayalaruano requested a review from enryH May 1, 2025 11:46
@enryH
Copy link
Collaborator

enryH commented May 1, 2025

Do you want to keep the folder docs/sections_readme as a dump of the current README? Alternatively you could document this step in docs/README.md. As we anyways do not often build the docs locally, this is in my opinion good enough.

Copy link
Collaborator

@enryH enryH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.


VueGen’s functionality is demonstrated through two case studies:

**1. Predefined Directory**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you want to add headlines here?

@@ -0,0 +1,58 @@
## Case studies
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be that sphinx will complain about the headlines. Check the logs, but if you split up the README, you could remove one hashtag per headline...

That said, the website looks good, so no big issue

@@ -0,0 +1,22 @@
## Citation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and it's everywhere in your dumps

@sayalaruano sayalaruano merged commit e59eec3 into main May 1, 2025
16 checks passed
@sayalaruano sayalaruano deleted the split-readme-docs branch May 1, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants