Tests for Config & Job Creation + XML Processing#1225
Merged
bishwaspraveen merged 30 commits intodevfrom Feb 28, 2025
Merged
Conversation
…dexer job creation.
…dexer job creation.
…xers' of https://github.com/NASA-IMPACT/COSMOS into 1052-update-cosmos-to-create-jobs-for-scrapers-and-indexers
…-update-cosmos-to-create-jobs-for-scrapers-and-indexers
…-update-cosmos-to-create-jobs-for-scrapers-and-indexers
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…github.com/NASA-IMPACT/COSMOS into 1190-add-tests-for-job-generation-pipeline
for more information, see https://pre-commit.ci
…github.com/NASA-IMPACT/COSMOS into 1190-add-tests-for-job-generation-pipeline
for more information, see https://pre-commit.ci
| def test_add_complex_element_structure(): | ||
| xml_string = "<root></root>" | ||
| editor = XmlEditor(xml_string) | ||
| editor.update_or_add_element_value("parent/child", "Nested") |
Contributor
There was a problem hiding this comment.
Could we have a test for checking a third level of hierarchy for this method? The test would be needed, and we could see how to go about updating the method to accommodate the same, if required.
…-add-tests-for-job-generation-pipeline
for more information, see https://pre-commit.ci
bishwaspraveen
deleted the
1190-add-tests-for-job-generation-pipeline
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #1190 and #3036