feat: Implement page footer with USWDS components#1285
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
renamed old footer to PageFooterLegacy
I suppose the content will be included in the new footer component
Contributes to the feature branch #1285 Hej @snmln ! Thanks for setting up the feature branch and foundations for the new footer component! I renamed the old footer to PageFooterLegacy, that way we can use the regular import path for our new footer component. Also added a .env var that allows us to switch between old and new footer implementations easily. Campground Rule[^1]: While working on the feature flag, I addressed an unrelated lint warning within the files I made changes to. [^1]: Always leave the campground cleaner than you found it.
AliceR
changed the title
**Related Ticket:** _{link related ticket here}_
### Description of Changes
Creating slim footer.
- Establishing initial Front-end
- Creating footer object model in veda.config.js
- Setting up initial default.config.js
- Wiring up Config data flow
- Turning USWDS breakpoints on
TO DO's for this PR:
- Implement dynamic creation of links in footer component
|
@faustoperez Can you take a look at the preview view here: https://deploy-preview-1285--veda-ui.netlify.app/ We have the front-end in place and are currently working through functionality. So this should be in a good spot for a design review. |
There was a problem hiding this comment.
In the spirit of not wanting to drag this out any longer, this looks good to me. Related to dropdowns i've just updated this #1323 to address it since its not a blocker. There are issues with lint and test in the built which will need to be fixed before merging otherwise 👍🏼 and great work!
app/scripts/components/common/page-footer/return-to-top-button/index.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: sandrahoang686 <sandrahoang686@gmail.com>
|
@faustoperez Could you take a quick look at this and provide your review: https://deploy-preview-1285--veda-ui.netlify.app/ |
Co-authored-by: sandrahoang686 <sandrahoang686@gmail.com>
Co-authored-by: sandrahoang686 <sandrahoang686@gmail.com>
sandrahoang686
left a comment
sandrahoang686
left a comment
There was a problem hiding this comment.
thanks for making the changes
faustoperez
left a comment
faustoperez
left a comment
There was a problem hiding this comment.
I understand this ticket captures the desktop work. If that's the case, everything is looking good!
The mobile adaptation will be implemented in a separate ticket, right?
|
That is correct the mobile breakpoints will be handled in this ticket: #1288 |
6 participants
Related Ticket: #1135
Description of Changes
TO DO:
Checkin with Fausto on progress.Notes & Questions About Changes
{Add additonal notes and outstanding questions here related to changes in this pull request}
Validation / Testing
{Update with info on what can be manually validated in the Deploy Preview link for example "Validate style updates to selection modal do NOT affect cards"}