-
Notifications
You must be signed in to change notification settings - Fork 14
feat: Implement page footer with USWDS components #1285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
a014680
initial commit
snmln 4e4fef7
adding outstanding footer imports
snmln 7f300ea
pushing up initial slim work
snmln 545697e
Move uswds footer behind feature flag
AliceR 6f58910
Disable eslint to not warn, explanation in comment
AliceR f838337
Move Connections component behind the same FF
AliceR 9f059df
Hide new USWDS footer behind feature flag (#1287)
snmln e856157
usa foot implementation
snmln a82d132
Merge branch 'main' into 1135-Refactor-Layout-Components-Footer
AliceR 65dacea
adding uswds style infrastructure
snmln 1aafd0c
Merge branch '1135-Refactor-Layout-Components-Footer' into 1135-slim-…
snmln 18f0173
implementing styling and creating interface
snmln 60398ed
wiring up config
snmln a5b4502
correcting styles
snmln c47e331
Merge branch '1135-Refactor-Layout-Components-Footer' into 1135-slim-…
snmln e629882
correct ts and lint errors
snmln a7a91ec
correctin merge conflict issues.
snmln d0a4cd4
updating styles
snmln 59dd97e
dialing in css
snmln 4bdf994
refactor: 1135 slim footer (#1308)
snmln e2afeed
Fix hideFooter prop name
AliceR 9f4a2fd
Add back comments to .env
AliceR fe545d4
Remove duplicated styles
AliceR f224268
wiring up menu items
snmln 02e5b61
fix: hideFooter prop name, small cleanup (#1315)
AliceR 89a9421
fix: svg logo to not require css styles
AliceR 0755ef6
Pass svg logo as prop to footer
AliceR 4e3a21a
fix: svg logo (#1316)
AliceR 2d175f1
adding comment in createDynamicNavMenuList
snmln 6bf3149
wirign up dynamic link creation
snmln bb5dcad
Merge branch '1135-Refactor-Layout-Components-Footer' into 1135-wirin…
snmln 886912e
cleaning up veda.config and styling
snmln 8c3c769
fix: 1135 wiring up veda config (#1320)
AliceR d830c03
Add comments to .env
AliceR 5089c7e
Revert "Add comments to .env"
AliceR 98fd9ed
Merge remote-tracking branch 'origin' into 1135-Refactor-Layout-Compo…
AliceR c7846f8
Remove TODO as completed
AliceR fc7d58e
Add page footer to exported components
AliceR 75f6fd3
createing jest tests
snmln d72afea
correcting test
snmln d43dccc
fix:1335 creating footer test suite (#1330)
AliceR a9fd5ce
Add secondary footer content to footer config
AliceR e039620
fix: Add secondary footer content to footer config (#1331)
snmln c13d9c1
Merge branch 'main' into 1135-Refactor-Layout-Components-Footer
AliceR 13c9cb9
Update color mappings, use system token instead of theme token
AliceR 8ff3230
Merge branch 'main' into 1135-Refactor-Layout-Components-Footer
AliceR b45d108
Replace values with theme vars
AliceR 3584e15
Add role and aria-label to svg logo
AliceR c149d5b
Merge branch 'main' into 1135-Refactor-Layout-Components-Footer
AliceR 23850fd
corrcting layout, line-height, and coloring issues
snmln 0c78b01
updating documentation
snmln c4f1b24
updating documentation
snmln b5fad30
updating tests
snmln 2267afc
Merge remote-tracking branch 'origin/main' into 1135-Refactor-Layout-…
snmln c0d279a
Update app/scripts/components/common/layout-root/index.tsx
snmln 8cfe1ce
implementing isUswdsFooterEnabled rename
snmln 6846e20
moving return to top button outside of footer
snmln 522dab0
fixing footer uswds import
snmln e8a7b14
eslint removal
snmln bda0bde
updating styles
snmln 73eff21
removing link in logo
snmln 9bbd492
implementing link properties
snmln 9877502
updating test names
snmln dc2d615
returntotop button
snmln 8b758bf
updating default settings and tests
snmln 09babe8
updating types import
snmln 48737c4
updating return to top focus
snmln eb8ad3e
implementing feedback
snmln 2ac6245
updating css
snmln 6712d33
Merge branch 'main' into 1135-Refactor-Layout-Components-Footer
snmln 46c2f17
type corrections
snmln 1d26ca0
Update app/scripts/components/common/types.ts
snmln 9c3cfde
Update app/scripts/components/common/page-footer/index.tsx
snmln 2048eea
Update app/scripts/components/common/page-footer/index.tsx
snmln 2e95ee0
turning off V2 implementations
snmln cd105ca
Merge remote-tracking branch 'origin/main' into 1135-Refactor-Layout-…
snmln File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import React from 'react'; | ||
| import NasaLogoColor from '../../nasa-logo-color'; | ||
|
|
||
| import { | ||
| USWDSFooter, | ||
| USWDSLink, | ||
| USWDSFooterNav, | ||
| USWDSLogo | ||
| } from '$components/common/uswds'; | ||
| export default function PageFooter() { | ||
| return ( | ||
| <> | ||
| <USWDSFooter | ||
| size='slim' | ||
| // returnToTop={returnToTop} | ||
| primary={ | ||
| <div className='usa-footer__primary-container grid-row bg-base-lightest'> | ||
| <div className='mobile-lg:grid-col-8'> | ||
| <USWDSFooterNav | ||
| size='slim' | ||
| links={Array(4).fill( | ||
| <USWDSLink | ||
| variant='nav' | ||
| href='#' | ||
| className='usa-footer__primary-link' | ||
| > | ||
| Primary Link | ||
| </USWDSLink> | ||
| )} | ||
| /> | ||
| </div> | ||
| </div> | ||
| } | ||
| secondary={ | ||
| <USWDSLogo | ||
| size='slim' | ||
| //Nasa logo not showing. | ||
| image={<NasaLogoColor />} | ||
| heading={<p className='usa-footer__logo-heading'>Name of Agency</p>} | ||
| /> | ||
| } | ||
| /> | ||
| </> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| @use '$styles/veda-ui-theme-vars.scss' as themeVars; | ||
snmln marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| .usa-footer__secondary-section { | ||
| color: themeVars.$veda-uswds-color-base-dark; | ||
| } | ||
| .usa-footer__primary-section { | ||
| color: themeVars.$veda-uswds-color-base-lightest; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import React from 'react'; | ||
| import { | ||
| Footer, | ||
| FooterNav, | ||
| SocialLink, | ||
| Logo, | ||
| Address, | ||
| FooterExtendedNavList | ||
| } from '@trussworks/react-uswds'; | ||
|
|
||
| export function USWDSFooter(props) { | ||
| return <Footer {...props} />; | ||
| } | ||
| export function USWDSFooterNav(props) { | ||
| return <FooterNav {...props} />; | ||
| } | ||
| export function USWDSSocialLink(props) { | ||
| return <SocialLink {...props} />; | ||
| } | ||
| export function USWDSLogo(props) { | ||
| return <Logo {...props} />; | ||
| } | ||
| export function USWDSAddress(props) { | ||
| return <Address {...props} />; | ||
| } | ||
| export function USWDSFooterExtendedNavList(props) { | ||
| return <FooterExtendedNavList {...props} />; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,16 @@ | ||
| export { USWDSAlert } from './alert'; | ||
| export { USWDSButtonGroup, USWDSButton } from './button'; | ||
| export { USWDSLink } from './link'; | ||
| export { USWDSBanner, USWDSBannerContent } from './banner'; | ||
| export { | ||
| USWDSFooter, | ||
| USWDSSocialLink, | ||
| USWDSLogo, | ||
| USWDSAddress, | ||
| USWDSFooterNav, | ||
| USWDSFooterExtendedNavList | ||
| } from './footer'; | ||
| export { USWDSHeader, USWDSHeaderTitle } from './header'; | ||
| export { USWDSNavMenuButton } from './header/nav-menu-button'; | ||
| export { USWDSExtendedNav } from './header/extended-nav'; | ||
| export { USWDSNavMenuButton } from './header/nav-menu-button'; | ||
| export { USWDSTextInput, USWDSTextInputMask } from './input'; | ||
| export { USWDSLink } from './link'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.