feat: start monorepo structure with veda-ui package by vgeorge · Pull Request #1898 · NASA-IMPACT/veda-ui

vgeorge · 2025-10-28T13:21:45Z

Summary

This PR introduces an early experiment toward a monorepo setup. It establishes a /packages and /apps structure and moves the main library code into packages/veda-ui. The goal is to explore the migration path and gather practical feedback before any broader restructuring decisions.

Contributes to:

Context

Based on my proposal on the ADR created by @AliceR. This is meant to complement it by prototyping a practical setup before committing to a full migration.

Changes

Moved app/scripts/ → packages/veda-ui/src/
Moved app/graphics/ → packages/veda-ui/graphics/
Added Yarn workspaces at root
Updated configs (tsconfig, gulpfile, vite, aliases`)
Fixed test and HTML paths
Kept lib/ and dist/ at root

Status

yarn buildlib, build, serve, test, and test:e2e all working
Existing builds appear unaffected

Potential Next Steps

Move app/ → apps/legacy-spa/
Move storybook/ → apps/storybook/
Review placement of mock/, test/, static/, and docs/
Revisit Parcel tooling and release process

Feedback and suggestions are welcome on the approach and possible next steps.

cc @dzole0311 @ifsimicoded @snmln @sandrahoang686 @aboydnw

- Move graphics to packages/veda-ui/graphics - Update parcel config to extend from root - Update gulpfile to use new source paths but keep lib output at root - Remove package.json from library package (uses root dependencies) - Add graphics alias to tsconfig and package.json - Library build now working successfully

- Add $mock and $test aliases to tsconfig and package.json - Fix test file imports to use aliases instead of relative paths - Fix import order in test files - TypeScript check now passes - Note: stylelint errors are pre-existing, not introduced by refactor

netlify · 2025-10-28T13:21:52Z

✅ Deploy Preview for veda-ui ready!

Name	Link
🔨 Latest commit	`5fc5e2c`
🔍 Latest deploy log	https://app.netlify.com/projects/veda-ui/deploys/693c0129e2bd4500080b8f7c
😎 Deploy Preview	https://deploy-preview-1898--veda-ui.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

dzole0311

Looks good as a first pass @vgeorge 👍

package.json

tsconfig.json

package.json

vgeorge · 2025-11-10T10:00:03Z

@dzole0311 thanks for the review! Given that veda-ui is entering in maintenance mode (see #1889), I'm not sure if we should keep working on this refactor as there isn't a clear need for it in v6. I would suggest we close this PR.

# Conflicts: # app/scripts/components/common/blocks/figure.js # app/scripts/components/common/blocks/images/compare.js # app/scripts/components/common/blocks/images/index.js # app/scripts/components/common/blocks/index.test.js # app/scripts/components/common/blocks/lazy-components.js # app/scripts/components/common/bounds-fieldset.js # app/scripts/components/common/cookie-consent/cookieConsent.spec.js # app/scripts/components/common/mdx-content.js # app/scripts/components/common/meta-tags.js # app/scripts/components/common/nasa-logo-color.js # app/scripts/components/common/nasa-logo.js # app/scripts/components/common/nav-wrapper.js # app/scripts/components/common/try-render.js # app/scripts/components/sandbox/cards/index.js # app/scripts/components/sandbox/index.js # app/scripts/components/sandbox/legacy/cards/index.js # app/scripts/components/sandbox/legacy/colors/index.js # app/scripts/components/sandbox/legacy/content-blocks/index.js # app/scripts/components/sandbox/legacy/exploration-map/index.js # app/scripts/components/sandbox/legacy/exploration/timeline-analysis/external-layer-card.js # app/scripts/components/sandbox/legacy/exploration/timeline-analysis/index.js # app/scripts/components/sandbox/legacy/hug/index.js # app/scripts/components/sandbox/legacy/layer-info/index.js # app/scripts/components/sandbox/legacy/map-block/index.js # app/scripts/components/sandbox/legacy/mdx-chart/index.js # app/scripts/components/sandbox/legacy/mdx-page/index.js # app/scripts/components/sandbox/legacy/mdx-scrollytelling/index.js # app/scripts/components/sandbox/legacy/request/index.js # app/scripts/components/sandbox/legacy/table/index.js # app/scripts/components/sandbox/legacy/typography/index.js # app/scripts/components/sandbox/override/index.js # app/scripts/components/uhoh/fatal-error.js # app/scripts/components/uhoh/index.js # package.json # packages/veda-ui/src/components/common/blocks/figure.js # packages/veda-ui/src/components/common/blocks/figure.jsx # packages/veda-ui/src/components/common/blocks/images/compare.js # packages/veda-ui/src/components/common/blocks/images/compare.jsx # packages/veda-ui/src/components/common/blocks/images/index.js # packages/veda-ui/src/components/common/blocks/images/index.jsx # packages/veda-ui/src/components/common/blocks/index.test.js # packages/veda-ui/src/components/common/blocks/index.test.jsx # packages/veda-ui/src/components/common/blocks/lazy-components.js # packages/veda-ui/src/components/common/blocks/lazy-components.jsx # packages/veda-ui/src/components/common/bounds-fieldset.js # packages/veda-ui/src/components/common/bounds-fieldset.jsx # packages/veda-ui/src/components/common/cookie-consent/cookieConsent.spec.js # packages/veda-ui/src/components/common/cookie-consent/cookieConsent.spec.jsx # packages/veda-ui/src/components/common/mdx-content.js # packages/veda-ui/src/components/common/mdx-content.jsx # packages/veda-ui/src/components/common/meta-tags.js # packages/veda-ui/src/components/common/meta-tags.jsx # packages/veda-ui/src/components/common/nasa-logo-color.js # packages/veda-ui/src/components/common/nasa-logo-color.jsx # packages/veda-ui/src/components/common/nasa-logo.js # packages/veda-ui/src/components/common/nasa-logo.jsx # packages/veda-ui/src/components/common/nav-wrapper.js # packages/veda-ui/src/components/common/nav-wrapper.jsx # packages/veda-ui/src/components/common/try-render.js # packages/veda-ui/src/components/common/try-render.jsx # packages/veda-ui/src/components/exploration/components/map/share-button.tsx # packages/veda-ui/src/components/sandbox/cards/index.js # packages/veda-ui/src/components/sandbox/cards/index.jsx # packages/veda-ui/src/components/sandbox/index.js # packages/veda-ui/src/components/sandbox/index.jsx # packages/veda-ui/src/components/sandbox/legacy/cards/index.js # packages/veda-ui/src/components/sandbox/legacy/cards/index.jsx # packages/veda-ui/src/components/sandbox/legacy/colors/index.js # packages/veda-ui/src/components/sandbox/legacy/colors/index.jsx # packages/veda-ui/src/components/sandbox/legacy/content-blocks/index.js # packages/veda-ui/src/components/sandbox/legacy/content-blocks/index.jsx # packages/veda-ui/src/components/sandbox/legacy/exploration-map/index.js # packages/veda-ui/src/components/sandbox/legacy/exploration-map/index.jsx # packages/veda-ui/src/components/sandbox/legacy/exploration/timeline-analysis/external-layer-card.js # packages/veda-ui/src/components/sandbox/legacy/exploration/timeline-analysis/external-layer-card.jsx # packages/veda-ui/src/components/sandbox/legacy/exploration/timeline-analysis/index.js # packages/veda-ui/src/components/sandbox/legacy/exploration/timeline-analysis/index.jsx # packages/veda-ui/src/components/sandbox/legacy/hug/index.js # packages/veda-ui/src/components/sandbox/legacy/hug/index.jsx # packages/veda-ui/src/components/sandbox/legacy/layer-info/index.js # packages/veda-ui/src/components/sandbox/legacy/layer-info/index.jsx # packages/veda-ui/src/components/sandbox/legacy/map-block/index.js # packages/veda-ui/src/components/sandbox/legacy/map-block/index.jsx # packages/veda-ui/src/components/sandbox/legacy/mdx-chart/index.js # packages/veda-ui/src/components/sandbox/legacy/mdx-chart/index.jsx # packages/veda-ui/src/components/sandbox/legacy/mdx-page/index.js # packages/veda-ui/src/components/sandbox/legacy/mdx-page/index.jsx # packages/veda-ui/src/components/sandbox/legacy/mdx-scrollytelling/index.js # packages/veda-ui/src/components/sandbox/legacy/mdx-scrollytelling/index.jsx # packages/veda-ui/src/components/sandbox/legacy/request/index.js # packages/veda-ui/src/components/sandbox/legacy/request/index.jsx # packages/veda-ui/src/components/sandbox/legacy/table/index.js # packages/veda-ui/src/components/sandbox/legacy/table/index.jsx # packages/veda-ui/src/components/sandbox/legacy/typography/index.js # packages/veda-ui/src/components/sandbox/legacy/typography/index.jsx # packages/veda-ui/src/components/sandbox/override/index.js # packages/veda-ui/src/components/sandbox/override/index.jsx # packages/veda-ui/src/components/uhoh/fatal-error.js # packages/veda-ui/src/components/uhoh/fatal-error.jsx # packages/veda-ui/src/components/uhoh/index.js # packages/veda-ui/src/components/uhoh/index.jsx

Addresses PR feedback to include apps/* in workspaces alongside packages/* for proper monorepo setup.

vgeorge · 2025-11-25T12:12:01Z

I reopened this PR because it helps move #1871 across the finish line and improves the overall maintainability of the library.

@dzole0311 I made some updates and responded to your comments. I think we should keep the scope of this PR limited to isolating the library files.

This is ready for another review.

dzole0311 · 2025-11-25T12:52:59Z

@vitor sounds good. I pulled the branch locally and everything looks fine 👍 One question before we merge: should we also do a global search here and replace leftover paths like app/scripts to match the new path structure?

# Conflicts: # packages/veda-ui/src/components/exploration/atoms/center.ts # packages/veda-ui/src/components/exploration/atoms/embed.ts # packages/veda-ui/src/components/exploration/atoms/zoom.ts # packages/veda-ui/src/components/exploration/components/embed-exploration/embed-timeline.tsx # packages/veda-ui/src/components/exploration/embed-exploration.tsx

Update all app/scripts and app/graphics references to packages/veda-ui/src and packages/veda-ui/graphics across configs and documentation.

- Move exploration view components from app/scripts/ to packages/veda-ui/src/components/exploration/views/ - Fix import in container.tsx to use ExplorationAndAnalysisDefaultView directly - Remove workspaces configuration from package.json (not a full monorepo yet) - Clean up empty app/scripts directory structure All checks passing: lint, TypeScript, and tests

vgeorge · 2025-12-12T12:26:58Z

Status update:

Removed leftover app/scripts paths
Merged and fixed conflicts with main
Removed workspaces property from package.json as this the codebase is not ready yet to work as a monorepo

@dzole0311 can you please have another look?

…PACT/veda-ui#1898)

- Document evolution from Option C to Option D (monorepo structure) - Update status to reflect PR #1898 merge - Add action items from PR #1871 discussion - Capture ifsimicoded's concerns about broader developer experience - Update implementation plan to reflect actual monorepo structure - Remove outdated /core references and verbose content

vgeorge added 13 commits October 28, 2025 11:15

chore: initialize yarn workspaces

18298c5

chore: create library package.json

3b5e8b2

refactor: move library source to packages/veda-ui/src

d3552b6

refactor: update tsconfig path aliases for new structure

cdf4a3e

refactor: update package.json aliases for new structure

b0f8c0d

refactor: update gulpfile library entry point path

13599ee

refactor: update gulpfile library output directory

a869f1b

refactor: update buildlib script for new lib location

728b61e

refactor: move parcel library config to package directory

0e6264b

refactor: update parcelLibConfig path reference

6e3b6dd

fix: path in index.html

efc6f6b

fix: update stylelint ignore paths for monorepo structure

456ee99

dzole0311 reviewed Oct 29, 2025

View reviewed changes

package.json Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

tsconfig.json Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

vgeorge mentioned this pull request Oct 30, 2025

fix: Rename React component files from .js to .jsx #1901

Merged

vgeorge mentioned this pull request Nov 11, 2025

VEDA-UI Maintenance Mode #1912

Open

vgeorge closed this Nov 11, 2025

vgeorge mentioned this pull request Nov 11, 2025

docs: Add ADR 004 - Component Library Restructure #1871

Merged

7 tasks

vgeorge reopened this Nov 25, 2025

vgeorge added 3 commits November 25, 2025 10:37

chore: add apps/* to workspaces configuration

8948c84

Addresses PR feedback to include apps/* in workspaces alongside packages/* for proper monorepo setup.

chore: mark package as private for workspaces

2616b34

vgeorge requested a review from dzole0311 November 25, 2025 12:08

vgeorge requested review from AliceR and ifsimicoded November 25, 2025 12:12

vgeorge added 3 commits November 28, 2025 16:05

fix: update leftover paths for monorepo structure

5dd8941

Update all app/scripts and app/graphics references to packages/veda-ui/src and packages/veda-ui/graphics across configs and documentation.

vgeorge removed the request for review from AliceR December 12, 2025 11:50

dzole0311 approved these changes Dec 12, 2025

View reviewed changes

dzole0311 added a commit to NASA-IMPACT/veda-config that referenced this pull request Dec 12, 2025

chore: update paths based on monorepo changes in veda-ui (see NASA-IM…

9761c01

…PACT/veda-ui#1898)

vgeorge merged commit 4796ef2 into main Dec 12, 2025
14 of 15 checks passed

vgeorge deleted the feat/monorepo branch December 12, 2025 12:46

dzole0311 mentioned this pull request Dec 12, 2025

chore: update paths based on monorepo changes in veda-ui NASA-IMPACT/veda-config#953

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: start monorepo structure with veda-ui package#1898

feat: start monorepo structure with veda-ui package#1898
vgeorge merged 20 commits intomainfrom
feat/monorepo

vgeorge commented Oct 28, 2025

Uh oh!

netlify bot commented Oct 28, 2025 •

edited

Loading

Uh oh!

dzole0311 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vgeorge commented Nov 10, 2025

Uh oh!

vgeorge commented Nov 25, 2025

Uh oh!

dzole0311 commented Nov 25, 2025

Uh oh!

vgeorge commented Dec 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

vgeorge commented Oct 28, 2025

Summary

Context

Changes

Status

Potential Next Steps

Uh oh!

netlify bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for veda-ui ready!

Uh oh!

dzole0311 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vgeorge commented Nov 10, 2025

Uh oh!

vgeorge commented Nov 25, 2025

Uh oh!

dzole0311 commented Nov 25, 2025

Uh oh!

vgeorge commented Dec 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Oct 28, 2025 •

edited

Loading