fix: Rename React component files from .js to .jsx #1901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed 33 files that import React to have .jsx extension - This prepares the codebase for modern build tools like Vite - Library build with Parcel tested and working correctly - Vite build recognizes JSX syntax (SASS config needed separately) This is a preparatory step for the monorepo migration where we plan to migrate from Parcel to Vite for library builds.
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ifsimicoded
approved these changes
Oct 30, 2025
Contributor
There was a problem hiding this comment.
I'm not sure the specifics of what should be checked or the review process, so you may want another's 👀 . But this seems like a simple change to me -- if the app transpiles/builds it should be good to go! That said, I saw this thread on adjusting the vite config to accept jsx within js files for esbuild, but haven't tested.
Related, curious if we'll move to tsx and introduce typing? 🚀
Contributor
Author
|
@ifsimicoded thanks for the review! This is a fairly straightforward change, I believe it’s safe to just rename the files. The current build tooling is quite lax with file extensions, but Vite isn’t (unless you use a workaround as you pointed out). Ideally, our component files should be .tsx, but I don’t think the effort is worth it in this case since the goal is simply to prepare for the migration to Vite. |
slesaad
added a commit
to US-GHG-Center/veda-config-ghg
that referenced
this pull request
Dec 9, 2025
- # Changelog - ## 🎉 Features - feat: Expose VedaMap [#1878](NASA-IMPACT/veda-ui#1878) - feat: migrate ExternalLinkFlag to USWDS [#1887](NASA-IMPACT/veda-ui#1887) - feat: Share button to URL shortener [#1905](NASA-IMPACT/veda-ui#1905) - feat: embed mode for e&a [#1922](NASA-IMPACT/veda-ui#1922) - ## 🚀 Improvements - chore: trigger netlify redeploy - refactor: Preset selector [#1874](NASA-IMPACT/veda-ui#1874) - refactor: retire Collecticons [#1893](NASA-IMPACT/veda-ui#1893) - refactor: migrate dataset layer card icons to USWDS [#1891](NASA-IMPACT/veda-ui#1891) - refactor: Replace Collecticons in legacy footer and connections section [#1890](NASA-IMPACT/veda-ui#1890) - refactor: migrate catalog components to USWDS (except catalog-card) [#1888](NASA-IMPACT/veda-ui#1888) - ci: prevent cleanup from deleting latest valid release tag [#1910](NASA-IMPACT/veda-ui#1910) - ci: disable the slack notifications until we stabilize the release workflow [#1909](NASA-IMPACT/veda-ui#1909) - ci: re-enable slack notifications for failed releases [#1911](NASA-IMPACT/veda-ui#1911) - docs: Update development instructions for storybook [#1914](NASA-IMPACT/veda-ui#1914) - test: Add micasa to mock datasets for testing cmr timeseries [#1896](NASA-IMPACT/veda-ui#1896) - ## 📊 Dataset Updates - fix: Updates for SEDAC dataset landing page[#840](#840) - ## 📝 Stories Updates - ## 🐛 Fixes - fix: make release workflow idempotent and reset version to last successful release [#1908](NASA-IMPACT/veda-ui#1908) - fix: wmts copy url [#1886](NASA-IMPACT/veda-ui#1886) - fix: 744/search bar fix [#1903](NASA-IMPACT/veda-ui#1903) - fix: Rename React component files from .js to .jsx [#1901](NASA-IMPACT/veda-ui#1901) - fix: migrate scrollytelling from CollecticonCircleXmark to USWDS [#1885](NASA-IMPACT/veda-ui#1885) - fix: remove Collecticons from EmptyHub and TimelineZoomControls components [#1884](NASA-IMPACT/veda-ui#1884) - fix: [veda-ui-1864] Update colormapscale to default to mdx rescale [#1916](NASA-IMPACT/veda-ui#1916) - fix: properly load API_URL_SHORTENER_ENDPOINT through VedaUI context [#1924](NASA-IMPACT/veda-ui#1924) - fix: Guided tour doesn't work in exported ExplorationAndAnalysis component [#1921](NASA-IMPACT/veda-ui#1921) - fix: selected pill alignment in data-catalog layer component [1932](NASA-IMPACT/veda-ui#1932) - fix: update compare swiper interactions to prevent interaction with map controls [#1930](NASA-IMPACT/veda-ui#1930) - fix: guard WMS date domain lookup in scrollytelling [1926](NASA-IMPACT/veda-ui#1926) - fix: update cmr query key to cache bust on start and end date [#1928](NASA-IMPACT/veda-ui#1928) - fix: add missing export for embedded exploration [#1933](NASA-IMPACT/veda-ui#1933) - fix: 1068 update mapbox compare [#1947](NASA-IMPACT/veda-ui#1947) - fix: Fix EMIT Bug with Overlapping Plumes [#798](US-GHG-Center/ghgc-architecture#798)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to:
Notes:
This is ready for review.